From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: Re: [Xen-changelog] If the 'cdrom=' option is specified in the definition file but media is Date: Mon, 10 Apr 2006 18:35:27 -0500 Message-ID: <443AEBBF.2010705@us.ibm.com> References: <443AA3F9.50609@us.ibm.com> <20060410192930.GA12825@leeni.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060410192930.GA12825@leeni.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ewan Mellor Cc: Ross Maxfield , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Ewan Mellor wrote: > On Mon, Apr 10, 2006 at 01:29:13PM -0500, Anthony Liguori wrote: > > >> Xen patchbot -3.0-testing wrote: >> >>> # HG changeset patch >>> # User kaf24@firebug.cl.cam.ac.uk >>> # Node ID fd526926e0d1c0671295aa7f4b952186c9345173 >>> # Parent 408f51a850f47af4db20f43f281935909d502511 >>> If the 'cdrom=' option is specified in the definition file but media is >>> not found in the CD drive then main() in vl.c exits and the guest appears >>> to hang. This patch modifies vl.c slightly to check for the presents of >>> media. If the cdrom cannot be opened then the cd entry is removed from >>> hd_filename[] and bs_table[] allowing the guest to continue initializing. >>> If the guest requires the CD media then the guest should report, gracefully >>> or otherwise, that it's missing. >>> >>> From: Ross Maxfield >>> >>> Signed-off-by: Keir Fraser >>> >>> >> Doesn't this need a Signed-off-by: Ross Maxfield ? >> > > People have been complaining that a patch should not retain the Signed-off-by > line if the patch has been modified, because they do not sign-off the modified > patch. If a patch needs minor changes before it can be committed, we can > either bounce it back to the author, which seems unnecessarily heavyweight, or > do what Keir's done here, and sign-off the patch himself. The From: line > retains the audit trail, credit, and copyright, and it's clear that Keir > himself thinks that this patch is acceptable. > Just so this doesn't get lost in the discussion, I meant to say that I was referring to the original submission. The original patch submission did not contain a Signed-off-by line. Regardless of the interpretation of the DCO, Ross should resubmit the patch with a Signed-off-by. Regards, Anthony Liguori > Ewan. >