Re: [PATCH] sparse: gcc 4.1 warnings

[Jeff Garzik <jeff@garzik.org>]

Morten Welinder wrote:
> This doesn't look quite right.
> 
> So it looks like gcc 4.1 complains over non-used values that are the
> result of a cast.  That feels obnoxious, but in this case maybe you

Yes, it is :)  See below for vanilla sparse build under gcc 4.1...


> could try just casting to void in add_ptr_list -- is the value ever
> used?

All uses except for add_pseudo() ignore the return value.

	Jeff



gcc -O -g -Wall -Wwrite-strings -fpic -DDEBUG   -c -o lib.o lib.c
In file included from lib.c:21:
lib.h: In function ‘add_symbol’:
lib.h:171: warning: value computed is not used
lib.h: In function ‘add_statement’:
lib.h:176: warning: value computed is not used
lib.h: In function ‘add_expression’:
lib.h:181: warning: value computed is not used
In file included from lib.c:28:
linearize.h: In function ‘add_bb’:
linearize.h:227: warning: value computed is not used
linearize.h: In function ‘add_instruction’:
linearize.h:232: warning: value computed is not used
linearize.h: In function ‘add_multijmp’:
linearize.h:237: warning: value computed is not used
linearize.h: In function ‘add_pseudo_ptr’:
linearize.h:266: warning: value computed is not used
gcc -O -g -Wall -Wwrite-strings -fpic -DDEBUG   -c -o scope.o scope.c
In file included from scope.c:15:
lib.h: In function ‘add_symbol’:
lib.h:171: warning: value computed is not used
lib.h: In function ‘add_statement’:
lib.h:176: warning: value computed is not used
lib.h: In function ‘add_expression’:
lib.h:181: warning: value computed is not used
gcc -O -g -Wall -Wwrite-strings -fpic -DDEBUG   -c -o expression.o 
expression.c
In file included from expression.c:21:
lib.h: In function ‘add_symbol’:
lib.h:171: warning: value computed is not used
lib.h: In function ‘add_statement’:
lib.h:176: warning: value computed is not used
lib.h: In function ‘add_expression’:
lib.h:181: warning: value computed is not used
[...]