Re: [PATCH 4/4] first conntrack ID must be 1 not 2

[Patrick McHardy <kaber@trash.net>]

Amin Azez wrote:
> Patrick McHardy wrote:
> 
>> Found the patch again. What it does is:
>>
>> - note entry of next conntrack to be dumped and keep a reference to it
>> - when continuing, look for the conntrack and continue at it if its
>>   still there
>> - if not, dump the entire bucket again
>>
>> In theory we could end up in an endless loop if the conntrack entry
>> we're keeping the reference to is deleted everytime we want to
>> continue dumping. 
> 
> 
> Why not defer the ip_conntrack_put until after ctnetlink_fill_info,
> would that avoid the problem altogether?
> 
> It's no longer the entry of the next conntrack but the entry of the last
> conntrack by the time it gets deleted then...? Or have I misunderstood
> the way in which the loop would occur?

Yes, the loop is interrupted when the skb is full and continued when
userspace issues the next recvmsg(). The reference is kept to find
the point where to continue.