Re: [PATCH] 2 of 3 kdump-ppc64-soft-reset-fixes

[David Wilder <dwilder@us.ibm.com>]

Olaf Hering wrote:

> On Mon, Apr 10, David Wilder wrote:
>
>
>  
>
>>+++ 2617-rc1/arch/powerpc/kernel/crash.c	2006-04-05 13:24:19.000000000 -0700
>>    
>>
>
>  
>
>>@@ -185,15 +277,14 @@ void default_machine_crash_shutdown(stru
>> 	 * The kernel is broken so disable interrupts.
>> 	 */
>> 	local_irq_disable();
>>-
>>-	if (ppc_md.kexec_cpu_down)
>>-		ppc_md.kexec_cpu_down(1, 0);
>>-
>> 	/*
>> 	 * Make a note of crashing cpu. Will be used in machine_kexec
>> 	 * such that another IPI will not be sent.
>>    
>>
>
>This change conflicts with the patch for interrupt shutdown. I guess
>both patches are needed, as each one fixes a different bug?
>
>http://ozlabs.org/pipermail/linuxppc-dev/2006-April/021855.html
>[PATCH] powerpc: Disable and EOI interrupts in machine_crash_shutdown()
>
>  
>

Yes both are needed,  I don t see the conflict.  If you apply interrupt 
shutdown first then the soft-reset patch.  It should work ok.


-- 
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA 
dwilder@us.ibm.com
(503)578-3789