From: David Lively <dlively@virtualiron.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] fix x86_64 builds that explicitly specify XEN_TARGET_ARCH
Date: Thu, 13 Apr 2006 10:55:15 -0400 [thread overview]
Message-ID: <443E6653.5060204@virtualiron.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
Trivial patch to fix x86_64 builds in which XEN_TARGET_ARCH
is specified on the make command line, e.g.:
make XEN_TARGET_ARCH=x86_64
This busted the vmxassist and hvmloader builds, which must
be done -m32. Using "override" in the vmxassist/hvmloader
Makefiles fixes the problem by not allowing this to be
overridden from the command line.
Signed-off-by: Dave Lively <dlively@virtualiron.com>
[-- Attachment #2: fix-explicit-x86_64-build.patch --]
[-- Type: text/x-patch, Size: 1203 bytes --]
# HG changeset patch
# User lively@dlively2
# Node ID 70fde73c168c7d0c6188882f4f05451ae6136a24
# Parent 2a6dbd9efc9dbea4ce4f5b9bdace87df3f19a55c
Fix x86_64 builds that specify XEN_TARGET_ARCH explicitly
on the make command line. (We must build hvmloader and
vmxassist for x86_32 even in this case. Now we don't let the
assignment that does this get overridden by the command-
line arg.)
diff -r 2a6dbd9efc9d -r 70fde73c168c tools/firmware/hvmloader/Makefile
--- a/tools/firmware/hvmloader/Makefile Tue Apr 11 15:53:00 2006 -0400
+++ b/tools/firmware/hvmloader/Makefile Thu Apr 13 10:24:54 2006 -0400
@@ -21,7 +21,7 @@
# External CFLAGS can do more harm than good.
CFLAGS :=
-XEN_TARGET_ARCH = x86_32
+override XEN_TARGET_ARCH = x86_32
XEN_ROOT = ../../..
include $(XEN_ROOT)/Config.mk
diff -r 2a6dbd9efc9d -r 70fde73c168c tools/firmware/vmxassist/Makefile
--- a/tools/firmware/vmxassist/Makefile Tue Apr 11 15:53:00 2006 -0400
+++ b/tools/firmware/vmxassist/Makefile Thu Apr 13 10:24:54 2006 -0400
@@ -21,7 +21,7 @@
# External CFLAGS can do more harm than good.
CFLAGS :=
-XEN_TARGET_ARCH = x86_32
+override XEN_TARGET_ARCH = x86_32
XEN_ROOT = ../../..
include $(XEN_ROOT)/Config.mk
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2006-04-13 14:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443E6653.5060204@virtualiron.com \
--to=dlively@virtualiron.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.