All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@free.fr>
To: bwong@pillardata.com, device-mapper development <dm-devel@redhat.com>
Subject: Re: Segfault running multipath -d -v 3 at HOL
Date: Thu, 13 Apr 2006 23:06:09 +0200	[thread overview]
Message-ID: <443EBD41.5060503@free.fr> (raw)
In-Reply-To: <1144886522.7553.6.camel@ca-bwong3.trans.corp>

Brian Wong a écrit :
> Hi Christophe,
>
> I'm seeing a segfault running `multipath -d -v 3` at HOL.  Here's the
> fix for the issue.  It might be worth applying similar logic fixes to
> the rest of the free_x() calls in free_config(); let me know if you want
> that patch too.
>   
Thanks. I applied this bit.
>  
> diff --git a/libmultipath/parser.c b/libmultipath/parser.c
> index 385e4fb..bb04968 100644
> --- a/libmultipath/parser.c
> +++ b/libmultipath/parser.c
> @@ -18,6 +18,7 @@
>   */
>  
>  #include <syslog.h>
>  
>  #include "parser.h"
>  #include "memory.h"
> @@ -110,6 +111,9 @@ free_keywords(vector keywords)
>  	struct keyword *keyword;
>  	int i;
>  
> +	if (!keywords) return;
> +
>  	for (i = 0; i < VECTOR_SIZE(keywords); i++) {
>  		keyword = VECTOR_SLOT(keywords, i);
>  		if (keyword->sub)
> @@ -483,3 +487,11 @@ init_data(char *conf_file, void (*init_k
>  
>  	return r;
>  }
>
>   
Regards,
cvaroqui

      reply	other threads:[~2006-04-13 21:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13  0:02 Segfault running multipath -d -v 3 at HOL Brian Wong
2006-04-13 21:06 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=443EBD41.5060503@free.fr \
    --to=christophe.varoqui@free.fr \
    --cc=bwong@pillardata.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.