From: Jeff Garzik <jgarzik@pobox.com>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fix a logic error in ahci_init_one()
Date: Fri, 14 Apr 2006 04:47:05 -0400 [thread overview]
Message-ID: <443F6189.7050204@pobox.com> (raw)
In-Reply-To: <1144999881.24774.9.camel@localhost.localdomain>
zhao, forrest wrote:
> Fix an bug in error handling, also variable
> pci_dev_busy has no use, remove it.
>
> Signed-off-by: Zhao Forrest <forrest.zhao@intel.com>
What logic error do you see?
pci_dev_busy has a clear use, as illustrated by the code: if the PCI
regions are reserved by another device, the device is in use, therefore
we should avoid killing the device with pci_disable_device().
Jeff
next prev parent reply other threads:[~2006-04-14 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 7:31 [PATCH] Fix a logic error in ahci_init_one() zhao, forrest
2006-04-14 8:47 ` Jeff Garzik [this message]
2006-04-14 9:12 ` zhao, forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443F6189.7050204@pobox.com \
--to=jgarzik@pobox.com \
--cc=forrest.zhao@intel.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.