From: Markus Elfring <Markus.Elfring@web.de>
To: Maksym Holovach <nergzd@nergzd723.xyz>,
Markuss Broks <markuss.broks@gmail.com>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Subject: Re: [PATCH 2/3] soc: samsung: Add a driver for Samsung SPEEDY host controller
Date: Sat, 14 Dec 2024 15:43:41 +0100 [thread overview]
Message-ID: <44419be4-65b3-41eb-a696-cfefae84a423@web.de> (raw)
In-Reply-To: <20241212-speedy-v1-2-544ad7bcfb6a@gmail.com>
…
> SPEEDY is a proprietary 1 wire serial bus used by Samsung
> in various devices …
You may occasionally put more than 57 characters into text lines
of such a change description.
…
> +++ b/drivers/soc/samsung/exynos-speedy.c
> @@ -0,0 +1,457 @@
…
> +static int _speedy_read(struct speedy_controller *speedy, u32 reg, u32 addr, u32 *val)
> +{
> + int ret;
> + u32 cmd, int_ctl, int_status;
> +
> + mutex_lock(&speedy->io_lock);
…
> + ret = speedy_int_clear(speedy);
> +
> + mutex_unlock(&speedy->io_lock);
> +
> + return ret;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&speedy->io_lock);”?
https://elixir.bootlin.com/linux/v6.13-rc2/source/include/linux/mutex.h#L201
Regards,
Markus
next prev parent reply other threads:[~2024-12-14 14:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 21:09 [PATCH 0/3] Add Samsung SPEEDY serial bus host controller driver Markuss Broks
2024-12-12 21:09 ` [PATCH 1/3] dt-bindings: soc: samsung: exynos-speedy: Document SPEEDY host controller bindings Markuss Broks
2024-12-12 22:30 ` Rob Herring (Arm)
2024-12-13 7:40 ` Krzysztof Kozlowski
2024-12-13 9:47 ` Markuss Broks
2024-12-12 21:09 ` [PATCH 2/3] soc: samsung: Add a driver for Samsung SPEEDY host controller Markuss Broks
2024-12-13 7:49 ` Krzysztof Kozlowski
2024-12-13 9:42 ` Markuss Broks
2024-12-13 13:55 ` Krzysztof Kozlowski
2024-12-14 12:06 ` Markuss Broks
2024-12-14 14:43 ` Markus Elfring [this message]
2024-12-17 17:31 ` Markuss Broks
2024-12-14 15:52 ` Christophe JAILLET
2024-12-17 17:28 ` Markuss Broks
2024-12-12 21:09 ` [PATCH 3/3] MAINTAINERS: Add entry for the Samsung Exynos " Markuss Broks
2024-12-13 8:42 ` [PATCH 0/3] Add Samsung SPEEDY serial bus host controller driver Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44419be4-65b3-41eb-a696-cfefae84a423@web.de \
--to=markus.elfring@web.de \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=nergzd@nergzd723.xyz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.