From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: dim@openvz.org, schwab@suse.de,
netfilter-devel@lists.netfilter.org, dev@openvz.org
Subject: Re: compat_xt_counters is not compatible
Date: Sun, 16 Apr 2006 17:07:26 +0200 [thread overview]
Message-ID: <44425DAE.3040007@trash.net> (raw)
In-Reply-To: <20060416.002436.108421304.davem@davemloft.net>
David S. Miller wrote:
> A struct containing a u64 has to be 64-bit aligned on at least sparc64
> and ppc64, both of which use the compat layer for 32-bit programs, so
> I think it's quite clear this will have to be implemented differently.
Do these alignment requirements also hold for 32bit compiled programms?
This is what we need to match with compat_xt_counters. Or in other
words: we need a type that when compiled for 64bit has the same
alignment requirements as structures with embedded u_int64_t members
compiled for 32bit on all architectures supporting CONFIG_COMPAT.
I don't think such a type exists, so I guess we'll have to use different
types depending on the architecture.
I'll send a patch to do that if there are no better suggestions.
next prev parent reply other threads:[~2006-04-16 15:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 17:12 compat_xt_counters is not compatible Andreas Schwab
2006-04-15 14:11 ` Dmitry Mishin
2006-04-15 14:16 ` Andreas Schwab
2006-04-15 16:14 ` Dmitry Mishin
2006-04-15 17:32 ` Andreas Schwab
2006-04-15 18:38 ` Dmitry Mishin
2006-04-15 22:09 ` Andreas Schwab
2006-04-16 6:28 ` Dmitry Mishin
2006-04-16 11:41 ` Andreas Schwab
2006-04-17 20:13 ` David S. Miller
2006-04-15 16:37 ` Patrick McHardy
2006-04-15 17:31 ` Andreas Schwab
2006-04-15 17:52 ` Patrick McHardy
2006-04-16 7:24 ` David S. Miller
2006-04-16 15:07 ` Patrick McHardy [this message]
2006-04-17 5:24 ` David S. Miller
2006-04-17 10:59 ` [RFC][PATCH] compat_uint64_t type Dmitry Mishin
2006-04-17 11:51 ` Andreas Schwab
2006-04-17 12:04 ` Dmitry Mishin
2006-04-17 14:05 ` Andreas Schwab
2006-04-17 15:47 ` Patrick McHardy
2006-04-17 16:03 ` Patrick McHardy
2006-04-17 20:20 ` David S. Miller
2006-04-21 0:07 ` Patrick McHardy
[not found] ` <jehd4sdvh1.fsf@sykes.suse.de>
2006-04-17 17:12 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44425DAE.3040007@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=dev@openvz.org \
--cc=dim@openvz.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.