Re: [Xenomai-core] [PATCH] let skins select nucleus features

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Philippe Gerum wrote:
> Jan Kiszka wrote:
>> Hi,
>>
>> this patch aims at avoiding to select unneeded nucleus features if no
>> user is requiring it in the skins. Particularly, it addresses the
>> nucleus registry and the pipes.
>>
>> I have spent no effort on 2.4 yet as I first want to wait for comments.
>> Furthermore, 2.4. is lacking "select", so the feature selection has to
>> remain manually there anyway.
> 
> Looks good. Merged, thanks.
> 

In the same sense, but not that comfortable, here is the a 2.4 variant
of the patch.

Jan

[-- Attachment #2: nucl-reg-select-2.4.patch --]
[-- Type: text/x-patch, Size: 2294 bytes --]

Index: ksrc/skins/vrtx/Config.in
===================================================================
--- ksrc/skins/vrtx/Config.in	(Revision 941)
+++ ksrc/skins/vrtx/Config.in	(Arbeitskopie)
@@ -2,4 +2,10 @@
 # Xenomai configuration for Linux v2.4
 #
 
+if [ "$CONFIG_XENO_OPT_REGISTRY" = "n" ]; then
+	comment 'VRTX emulator requires CONFIG_XENO_OPT_REGISTRY'
+else
+
 dep_tristate 'VRTX emulator' CONFIG_XENO_SKIN_VRTX $CONFIG_XENO_OPT_NUCLEUS
+
+fi
Index: ksrc/skins/vxworks/Config.in
===================================================================
--- ksrc/skins/vxworks/Config.in	(Revision 941)
+++ ksrc/skins/vxworks/Config.in	(Arbeitskopie)
@@ -2,4 +2,10 @@
 # Xenomai configuration for Linux v2.4
 #
 
+if [ "$CONFIG_XENO_OPT_REGISTRY" = "n" ]; then
+	comment 'VxWorks emulator requires CONFIG_XENO_OPT_REGISTRY'
+else
+
 dep_tristate 'VxWorks emulator' CONFIG_XENO_SKIN_VXWORKS $CONFIG_XENO_OPT_NUCLEUS
+
+fi
Index: ksrc/skins/native/Config.in
===================================================================
--- ksrc/skins/native/Config.in	(Revision 941)
+++ ksrc/skins/native/Config.in	(Arbeitskopie)
@@ -2,6 +2,10 @@
 # Xenomai configuration for Linux v2.4
 #
 
+if [ "$CONFIG_XENO_OPT_PERVASIVE" = "y" -a "$CONFIG_XENO_OPT_REGISTRY" = "n" ]; then
+	comment 'Native skin requires CONFIG_XENO_OPT_REGISTRY in pervasive mode'
+else
+
 dep_tristate 'Native skin' CONFIG_XENO_SKIN_NATIVE $CONFIG_XENO_OPT_NUCLEUS
 
 if [ "$CONFIG_XENO_SKIN_NATIVE" != "n" ]; then
@@ -24,3 +28,5 @@ if [ "$CONFIG_XENO_SKIN_NATIVE" != "n" ]
 	bool 'Interrupts' CONFIG_XENO_OPT_NATIVE_INTR
 	endmenu
 fi
+
+fi
Index: ksrc/nucleus/Config.in
===================================================================
--- ksrc/nucleus/Config.in	(Revision 941)
+++ ksrc/nucleus/Config.in	(Arbeitskopie)
@@ -17,11 +17,7 @@ if [ "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]
 	if [ "$CONFIG_XENO_OPT_PIPE" != "n" ]; then
 		int 'Number of pipe devices' CONFIG_XENO_OPT_PIPE_NRDEV 32
 	fi
-	if [ "$CONFIG_XENO_OPT_PERVASIVE" != "n" ]; then
-		define_bool CONFIG_XENO_OPT_REGISTRY y
-	else
-		bool 'Registry support' CONFIG_XENO_OPT_REGISTRY
-	fi
+	bool 'Registry support' CONFIG_XENO_OPT_REGISTRY
 	if [ "$CONFIG_XENO_OPT_REGISTRY" != "n" ]; then
 		int 'Number of registry slots' CONFIG_XENO_OPT_REGISTRY_NRSLOTS 512
 	fi