From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [patch] calloc arguments Date: Mon, 17 Apr 2006 18:19:38 -0500 Message-ID: <4444228A.4000405@us.ibm.com> References: <1145307019.16042.110.camel@basalt.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1145307019.16042.110.camel@basalt.austin.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Hollis Blanchard Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Hollis Blanchard wrote: > Hi, it looks like a few users of calloc had their arguments backwards. I > checked the other users and they seem fine. > > Since one of those is in ioemu code, does that mean we (I?) will be > submitting that bug to qemu upstream? > The bug isn't present in upstream QEmu as this file isn't present. I imagine this is part of the VNC patch that lives externally to QEmu. In general, QEmu does not use any calloc()'s and instead prefers to use a malloc wrapper (qemu_mallocz) within the actual emulator. Regards, Anthony Liguori