From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: adeos-main@gna.org,
Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Subject: Re: [Adeos-main] [PATCH] clean up latest ipipe-tracing changes
Date: Tue, 18 Apr 2006 14:42:47 +0200 [thread overview]
Message-ID: <4444DEC7.8040806@domain.hid> (raw)
In-Reply-To: <4443BF6E.907@domain.hid>
Jan Kiszka wrote:
> Hi,
>
> here is a suggestion to do a tiny cleanup of Gilles' cpuid-fix for the
> tracer. Sorry that I didn't comment on this earlier. Nothing critical
> though.
>
> I think it's better to drag the include/linux/compiler.h changes into
> the main patch instead of starting to use
> __attribute__((no_instrument_function)) all over the place just to avoid
> notrace (especially as I expect that Ingo's tracer will get merged
> anyway in the future). Moreover, local_irq_restore_hw_notrace & frieds
> are available even for !CONFIG_IPIPE_TRACE, so no need to differentiate
> here. Finally, I do not see a need for marking a static inline function
> non-traced.
>
> The patch does not seem to produce different binary code (I checked
> kernel/ipipe/tracer.o) - as expected.
>
Applied, leaving the ipipe_processor_id() unchanged though. Thanks.
--
Philippe.
next prev parent reply other threads:[~2006-04-18 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-17 16:16 [Adeos-main] [PATCH] clean up latest ipipe-tracing changes Jan Kiszka
2006-04-17 16:25 ` [Adeos-main] " Gilles Chanteperdrix
2006-04-17 17:02 ` Jan Kiszka
2006-04-17 17:49 ` Gilles Chanteperdrix
2006-04-18 12:42 ` Philippe Gerum [this message]
2006-04-19 19:02 ` [Adeos-main] " Jan Kiszka
2006-04-20 18:06 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4444DEC7.8040806@domain.hid \
--to=rpm@xenomai.org \
--cc=adeos-main@gna.org \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=jan.kiszka@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.