All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dimitry Andric <dimitry@andric.com>
To: Ben Dooks <ben-linux-arm@fluff.org>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: RFC: rename arch/arm/mach-s3c2410 to arch/arm/mach-s3c24xx
Date: Wed, 19 Apr 2006 13:01:16 +0200	[thread overview]
Message-ID: <4446187C.2090603@andric.com> (raw)
In-Reply-To: <20060418165204.GG2516@trinity.fluff.org>

Ben Dooks wrote:
> With the advent of the s3c2410 port adding support for
> more of the samsung SoC product line (s3c2440, s3c2442,
> s3c2400) there have been several requests by other people
> to rename the (in their opinion) increasingly inaccurate
> arch/arm/mach-s3c2410 to arch/arm/mach-s3c24xx.

Well, if you start this way, you might also consider renaming it to
mach-s3cxxxx, since Samsung also seems to have S3C3410, S3C44B0 and who
knows what else.  Otherwise you'd maybe have to do such an operation
again in the future...

Also, I've always found the dichotomy of having
"include/asm-arm/arch-s3c2410" and "arch/arm/mach-s3c2410" rather weird.
Isn't s3cxxxx an "architecture", instead of a specific machine?  If so,
arch/arm/arch-s3cxxxx would be more logical.

Anyway, by starting to rename directories, you start a never-ending
quest, and you'll stress the abilities of most version control systems
too.  Your huge diff for just one rename operation already shows this.

There are certainly a lot more directories (also not specifically
arm-related ones) in the Linux kernel source that could be renamed to be
more logical, but I'd say the cost is rather large.  E.g. difficulty
merging patches on older kernels and other version control difficulties.

Cheers,
Dimitry

       reply	other threads:[~2006-04-19 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060418165204.GG2516@trinity.fluff.org>
2006-04-19 11:01 ` Dimitry Andric [this message]
2006-04-19 11:20   ` RFC: rename arch/arm/mach-s3c2410 to arch/arm/mach-s3c24xx Komal Shah
2006-04-19 14:40   ` Bill Gatliff
2006-04-19 15:05   ` Russell King
2006-04-20 10:37     ` Andreas Schweigstill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4446187C.2090603@andric.com \
    --to=dimitry@andric.com \
    --cc=ben-linux-arm@fluff.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.