Re: [rfc] [patch] "frame number" size in hypercall ABI

[Joe Bonasera <joe.bonasera@sun.com>]

> Message: 3
> Date: Wed, 19 Apr 2006 08:24:44 +0100
> From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
> Subject: [Xen-devel] Re: [rfc] [patch] "frame number" size in
> 	hypercall ABI
> To: Hollis Blanchard <hollisb@us.ibm.com>
> Cc: xen-devel <xen-devel@lists.xensource.com>
> Message-ID: <e3a01a5452fa05ddd61fde154e01d557@cl.cam.ac.uk>
> Content-Type: text/plain; charset=US-ASCII; format=flowed
> 
> 
> On 18 Apr 2006, at 20:17, Hollis Blanchard wrote:
> 
...
>>
>>I also haven't converted Xen itself to use frameno_t except where
>>absolutely necessary. It isn't required to solve my immediate 
>>problem...
> 
> 
> I think the patch looks okay in principle, except I notice a couple of 
> 'framno_t' misspellings. I think 'pfn_t' would be more in keeping with 
> the Xen naming scheme for arbitrary page frame numbers, but perhaps 
> that name is a bit unnecessarily cryptic. What is the immediate problem 
> you're needing to solve?
> 
>   -- Keir

Please don't use pfn_t, that's what Solaris already uses internally for
physical frame numbers. In the Xen code for Solaris, I introduced
mfn_t as the corresponding type for Xen's machine frame numbers.
frameno_t is fine, as I can just define mfn_t and frameno_t to be
the same, but conflicting pfn_t's would be problematic.

Joe