From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: bb@kernelpanic.ru
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
kernel@linuxace.com, nipsy@bitgnome.net, jrlundgren@gmail.com,
cat@zip.com.au, djani22@dynamicweb.hu, yoseph.basri@gmail.com,
mykleb@no.ibm.com, olel@ans.pl, michal@feix.cz,
chris@scorpion.nl, netdev@vger.kernel.org,
jesse.brandeburg@gmail.com, ak@suse.de, jgarzik@pobox.com
Subject: Re: [TCP]: Fix truesize underflow
Date: Wed, 19 Apr 2006 09:07:00 -0700 [thread overview]
Message-ID: <44466024.9040800@intel.com> (raw)
In-Reply-To: <4445D305.8080505@kernelpanic.ru>
Boris B. Zhmurov wrote:
> Hello, Herbert Xu.
>
> On 19.04.2006 03:27 you said the following:
>
>> On Tue, Apr 18, 2006 at 01:22:56PM -0700, David S. Miller wrote:
>>
>>> I think it is deserving of some run time assertions, else these bugs
>>> will elude us continually. Luckily there are only a few places that
>>> would need the run time assertion checks on skb->truesize, and I'll
>>> try to spend a few cycles on implementing this soon.
>>
>>
>> Yes indeed. One place that comes to mind would be tcp_trim_head just
>> before we munge truesize.
>>
>> Cheers,
>
>
> I confirm, finally I don't see messages in dmesg about assertions.
> Nice work :)
>
I can also confirm that both machines here had no problems after
applying this patch. Good work!
next prev parent reply other threads:[~2006-04-19 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 12:32 [TCP]: Fix truesize underflow Herbert Xu
2006-04-18 16:29 ` Ingo Oeser
2006-04-18 20:19 ` David S. Miller
2006-04-18 20:22 ` David S. Miller
2006-04-18 23:27 ` Herbert Xu
2006-04-19 6:04 ` Boris B. Zhmurov
2006-04-19 6:40 ` Herbert Xu
2006-04-19 16:07 ` Jesse Brandeburg [this message]
2006-04-19 21:29 ` Krzysztof Oledzki
2006-04-19 16:53 ` Stephen Hemminger
2006-04-19 20:07 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44466024.9040800@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=ak@suse.de \
--cc=bb@kernelpanic.ru \
--cc=cat@zip.com.au \
--cc=chris@scorpion.nl \
--cc=davem@davemloft.net \
--cc=djani22@dynamicweb.hu \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@gmail.com \
--cc=jgarzik@pobox.com \
--cc=jrlundgren@gmail.com \
--cc=kernel@linuxace.com \
--cc=michal@feix.cz \
--cc=mykleb@no.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nipsy@bitgnome.net \
--cc=olel@ans.pl \
--cc=yoseph.basri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.