Re: [PATCH] dvb-core: ULE fixes and RFC4326 additions (kernel 2.6.16)

[Christian Praehauser <cpraehaus@cosy.sbg.ac.at>]

Andrew Morton wrote:

>>After correcting the broadcast address i saw that broadcast packets are 
>> not accepted when in "multicast" mode (RX_MODE_MULTI).
>> In the attached version of the patch this was fixed.
>>    
>>
>
>This driver would have to be one of the ugliest-looking things in the
>kernel.  You must have a strong stomach.
>
>  
>
Well, yes ;-).
I agree with you, but i did not have the time and the courage to redo 
the whole thing.
The original goal was to fix the support for ULE extension headers (e.g. 
for link layer security, FEC, etc.),
which is broken in the current kernel versions.

I would welcome a discussion for beautifying the dvb-core (especially 
dvb_net.c) module.

>> --- drivers/media/dvb/dvb-core/dvb_net.c.orig	2006-04-19 15:12:31.000000000 +0200
>> +++ drivers/media/dvb/dvb-core/dvb_net.c	2006-04-20 11:04:18.000000000 +0200
>>    
>>
>
>Please prepare future patches in `patch -p1' form:
>
>--- a/drivers/media/dvb/dvb-core/dvb_net.c
>+++ a/drivers/media/dvb/dvb-core/dvb_net.c
>  
>
Thanks for the hint. Will do so in future patches.

Have a nice day!
Christian.

-- 
________________________________________
| Christian Praehauser                  |
|---------------------------------------|
| Email:                                |
|  cpraehaus@cosy.sbg.ac.at             |
| Address:                              |
|  Institut fuer Computerwissenschaften | 
|  Jakob-Haringer-Strasse 2             |
|  A-5020 Salzburg, Austria             |
|_______________________________________|