From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] change dom0 headers path Date: Thu, 20 Apr 2006 09:43:19 -0500 Message-ID: <44479E07.5020003@us.ibm.com> References: <20060420123936.GA840@totally.trollied.org> <444792C2.7050703@us.ibm.com> <8ab943f8056ddeae5d130d695e5b4d56@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8ab943f8056ddeae5d130d695e5b4d56@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, John Levon List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > > On 20 Apr 2006, at 14:55, Anthony Liguori wrote: > >> Because libxc "leaks" a few of the dom0_op structures like >> dom0_getvcpuinfo_t, dom0_shadow_control_stats_t, etc in its public >> interface. This could be fixed by making sure all of those >> structures had wrapper (like xc_dominfo_t). > > Those are defined in Xen public header files, not in Linux's privcmd.h. Yes, sorry, I read the first mail to quickly. This is another of my gripes though (it would be nice if xenctrl.h didn't pull in the Xen public headers too). About privcmd.h, the users of it are making hypercalls that aren't exposed through libxenctrl. Those users probably ought to add the appropriate plumbing to libxenctrl. This includes the ACM stuff, xenmon/xentrace, and xenstat. Regards, Anthony Liguori > -- Keir >