From: Jeff Garzik <jeff@garzik.org>
To: Andy Fleming <afleming@freescale.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] Fix locking in gianfar
Date: Thu, 20 Apr 2006 17:40:10 -0400 [thread overview]
Message-ID: <4447FFBA.50002@garzik.org> (raw)
In-Reply-To: <9312C75A-DB98-4818-859E-906FA6461489@freescale.com>
Andy Fleming wrote:
> This patch fixes several bugs in the gianfar driver, including a major one
> where spinlocks were horribly broken:
>
> * Split gianfar locks into two types: TX and RX
> * Made it so gfar_start() now clears RHALT
> * Fixed a bug where calling gfar_start_xmit() with interrupts off would
> corrupt the interrupt state
> * Fixed a bug where a frame could potentially arrive, and never be handled
> (if no more frames arrived
> * Fixed a bug where the rx_work_limit would never be observed by the rx
> completion code
> * Fixed a bug where the interrupt handlers were not actually protected by
> their spinlocks
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
ACK but failed:
[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'Fix locking in gianfar'
fatal: corrupt patch at line 19
prev parent reply other threads:[~2006-04-20 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 1:36 [PATCH] Fix locking in gianfar Andy Fleming
2006-04-20 21:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4447FFBA.50002@garzik.org \
--to=jeff@garzik.org \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.