Re: [PATCH][RFC] NFS: Adding hooks to enable the use of FS-Cache

[Steve Dickson <SteveD@redhat.com>]

Trond Myklebust wrote:
> On Fri, 2006-04-21 at 11:14 -0400, Steve Dickson wrote:
> 
>>This patch (based on Trond's nfs-2.6 git tree) adds the hooks need to
>>allow NFS to use the generic filesystem caching facility FS-Cache.
>>Caching is done on a per mount bases. To activate caching, the 'fsc'
>>flag is need as a mount option.
>>Ex:
>>     mount -o fsc server:/export /mnt
>>
>>(binary and source rpms as well as the actual patch are available at
>>  http://people.redhat.com/steved/cachefs/util-linux/)
> 
> 
> Hmm... Are you sure that is based on the latest trees? 
Just this morning I did an git fetch on my cloned nfs-2.6
tree... and everything seem to apply just fine...

> AFAICS it shouldn't even apply to stock 2.6.17-rc2 since it doesn't take into
> account the fact that we already use PagePrivate()+nfs_invalidatepage in
> order to fix truncate races.
hmm... I did not see that... so there must a disconnect somewhere...

> Could you look into that please?
Will do...

steved.