From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FX019-00050x-2m
	for qemu-devel@nongnu.org; Fri, 21 Apr 2006 14:06:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FX017-0004yW-TX
	for qemu-devel@nongnu.org; Fri, 21 Apr 2006 14:06:06 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FX017-0004y5-Kz
	for qemu-devel@nongnu.org; Fri, 21 Apr 2006 14:06:05 -0400
Received: from [24.93.47.41] (helo=ms-smtp-02.texas.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FX02j-0007fe-1W
	for qemu-devel@nongnu.org; Fri, 21 Apr 2006 14:07:45 -0400
Received: from [192.168.0.11] (cpe-67-9-160-120.austin.res.rr.com
	[67.9.160.120])
	by ms-smtp-02.texas.rr.com (8.13.4/8.13.4) with ESMTP id k3LI63pt024848
	for <qemu-devel@nongnu.org>; Fri, 21 Apr 2006 13:06:03 -0500 (CDT)
Message-ID: <44491F0A.2090608@austin.rr.com>
Date: Fri, 21 Apr 2006 13:06:02 -0500
From: Lonnie Mendez <lmendez19@austin.rr.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Large USB patch
References: <4447E811.1040403@gmx.de> <4448F1F6.4090609@austin.rr.com>
	<4448FF3F.3030009@austin.rr.com> <44490614.50406@austin.rr.com>
	<44490852.2080608@gmx.de> <44491659.30804@austin.rr.com>
In-Reply-To: <44491659.30804@austin.rr.com>
Content-Type: multipart/mixed; boundary="------------020807040900060101040505"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------020807040900060101040505
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Lonnie Mendez wrote:

>   There is some funkiness going on with removing the device in the 
> linux guest once attached.  Not sure what it is yet.

   This problem is addressed in the attached patch.

--------------020807040900060101040505
Content-Type: text/plain;
 name="qemu-uhci-portdisc.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="qemu-uhci-portdisc.diff"

--- a/qemu/hw/usb-uhci.c	2006-04-21 11:15:40.000000000 -0500
+++ b/qemu/hw/usb-uhci.c	2006-04-21 12:57:04.000000000 -0500
@@ -382,8 +392,9 @@
     } else {
         port = &s->ports[portnum];
         /* set connect status */
-        if (!(port->ctrl & UHCI_PORT_CCS)) {
-            port->ctrl |= UHCI_PORT_CCS | UHCI_PORT_CSC;
+        if (port->ctrl & UHCI_PORT_CCS) {
+            port->ctrl &= ~UHCI_PORT_CCS;
+            port->ctrl |= UHCI_PORT_CSC;
         }
         /* disable port */
         if (port->ctrl & UHCI_PORT_EN) {

--------------020807040900060101040505--