From: Mark Lord <liml@rtr.ca>
To: Al Boldi <a1426z@gawab.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [FIX] ide-io: increase timeout value to allow for slave wakeup
Date: Sun, 23 Apr 2006 21:14:12 -0400 [thread overview]
Message-ID: <444C2664.7060803@rtr.ca> (raw)
In-Reply-To: <200604231422.31176.a1426z@gawab.com>
Al Boldi wrote:
..
> Also apply this one to get rid of this message:
>
> hdb: set_drive_speed_status: status=0x40 { DriveReady }
> ide: failed opcode was: unknown
>
> Maybe someone on the ide list can comment on this first though.
>
> --- 16/include/linux/ide.h.orig 2006-03-31 19:12:51.000000000 +0300
> +++ 16/include/linux/ide.h 2006-04-23 13:06:32.000000000 +0300
> @@ -120,7 +120,7 @@ typedef unsigned char byte; /* used ever
> #define IDE_BCOUNTL_REG IDE_LCYL_REG
> #define IDE_BCOUNTH_REG IDE_HCYL_REG
>
> -#define OK_STAT(stat,good,bad) (((stat)&((good)|(bad)))==(good))
> +#define OK_STAT(stat,good,bad) (((stat)&((good)|(bad)))==((stat)&(good)))
> #define BAD_R_STAT (BUSY_STAT | ERR_STAT)
> #define BAD_W_STAT (BAD_R_STAT | WRERR_STAT)
> #define BAD_STAT (BAD_R_STAT | DRQ_STAT)
>
Assuming hdb is a CDROM/optical drive, then this change makes sense for that.
But I don't think it is a valid (good) change for regular ATA disks.
A more complex patch is required, one which correctly handles each drive type.
cheers
prev parent reply other threads:[~2006-04-24 1:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-22 20:59 [FIX] ide-io: increase timeout value to allow for slave wakeup Al Boldi
2006-04-22 21:58 ` Andrew Morton
2006-04-23 4:21 ` Al Boldi
2006-04-23 4:43 ` Andrew Morton
2006-04-23 11:22 ` Al Boldi
2006-04-24 1:14 ` Mark Lord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444C2664.7060803@rtr.ca \
--to=liml@rtr.ca \
--cc=a1426z@gawab.com \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.