Re: missing snd_dlclose in timer.c

[Benoit Fouet <benoit.fouet@purplelabs.com>]

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]



Takashi Iwai wrote:

>At Tue, 25 Apr 2006 16:30:08 +0200,
>Benoit Fouet wrote:
>  
>
>>Takashi Iwai wrote:
>>
>>    At Tue, 25 Apr 2006 11:03:28 +0200,
>>    Benoit Fouet wrote:
>>
>>        Hi,
>>        
>>        I worked on an ARM9E platform with not much memory. We had to
>>        dynamically link the libraries we needed.
>>        BTW I found out that there was a dlclose missing in ALSA lib in the
>>        snd_timer_open_conf function.
>>        Find below the diff of my file, if you want to add it in th hg repository.
>>
>>    A good catch.
>>    
>>    I just wonder whether it's safe to call dlclose() there.
>>    Can the callback functions dynamically registered by open
>>    (e.g. snd_timer_hw_open) be still accessed safely after dlclose()?
>>    
>>    Or should we keep dl handle and dlclose it in snd_timer_close()?
>>
>>    Takashi
>>
>>It surely is safer to keep the library opened as long as its symbol are likely to be
>>used.
>>I'm afraid I'm not aware enough of how it works to answer more clearly.
>>btw, the symbols I used were in asound library, and were consequently still reachable
>>after dlclose as the library was not really unloaded.
>>Keeping the handle must be the best way to guarantee symbols can be reached until
>>snd_timer_close.
>>    
>>
>
>I guess so, too.  alsa-lib has a mechanism to allow users specifying
>an extra shared object to be loaded.  Thus symbols are not always in
>libasound.so that is kept opened.
>
>I'll fix codes to call snd_dlclose() in close.
>
>  
>
Ok, thank you for precision :)

Ben


[-- Attachment #2: Type: text/html, Size: 1933 bytes --]