Re: [Qemu-devel] qemu/hw usb-uhci.c

[Fabrice Bellard <fabrice@bellard.org>]

OK for the UHCI fix.

I need more time to accept your big patch. I think it would have been 
better to separate the bug fixes, the new USB host drivers and the API 
changes. I would have included the first two without problem, but I need 
to better understand your API changes before commiting them.

Regards,

Fabrice.

nix.wie.weg@gmx.de wrote:
> Hello Fabrice,
> 
> This patch introduces an already fixed bug with linux guest os. The
> message is: "controller still running". The attached patch fixes this
> problem.
> Believe me it would save both of us a lot of time, if you would simply
> add the large usb patch.
> 
> With kind regards,
> Tino H. Seifert
> 
> Fabrice Bellard wrote:
> 
>>CVSROOT:	/sources/qemu
>>Module name:	qemu
>>Branch: 	
>>Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/24 21:38:50
>>
>>Modified files:
>>	hw             : usb-uhci.c 
>>
>>Log message:
>>	HCHALTED status bit handling (Lonnie Mendez)
>>
>>CVSWeb URLs:
>>http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
>>
>>
>>_______________________________________________
>>Qemu-devel mailing list
>>Qemu-devel@nongnu.org
>>http://lists.nongnu.org/mailman/listinfo/qemu-devel
>>
>>
>>  
>>
>>
>>------------------------------------------------------------------------
>>
>>Index: hw/usb-uhci.c
>>===================================================================
>>RCS file: /sources/qemu/qemu/hw/usb-uhci.c,v
>>retrieving revision 1.7
>>diff -u -r1.7 usb-uhci.c
>>--- hw/usb-uhci.c	24 Apr 2006 21:38:50 -0000	1.7
>>+++ hw/usb-uhci.c	24 Apr 2006 23:00:49 -0000
>>@@ -175,7 +175,7 @@
>>             /* start frame processing */
>>             qemu_mod_timer(s->frame_timer, qemu_get_clock(vm_clock));
>>             s->status &= ~UHCI_STS_HCHALTED;
>>-        } else if (!(val & UHCI_CMD_RS) && !(s->cmd & UHCI_CMD_RS)) {
>>+        } else if (!(val & UHCI_CMD_RS)) {
>>             s->status |= UHCI_STS_HCHALTED;
>>         }
>>         if (val & UHCI_CMD_GRESET) {
>>
>>
>>------------------------------------------------------------------------
>>
>>_______________________________________________
>>Qemu-devel mailing list
>>Qemu-devel@nongnu.org
>>http://lists.nongnu.org/mailman/listinfo/qemu-devel