From: Corey Minyard <minyard@acm.org>
To: "Gross, Mark" <mark.gross@intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
bluesmoke-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
"Carbonari, Steven" <steven.carbonari@intel.com>,
"Ong, Soo Keong" <soo.keong.ong@intel.com>,
"Wang, Zhenyu Z" <zhenyu.z.wang@intel.com>
Subject: Re: Problems with EDAC coexisting with BIOS
Date: Tue, 25 Apr 2006 21:19:09 -0500 [thread overview]
Message-ID: <444ED89D.8020405@acm.org> (raw)
In-Reply-To: <5389061B65D50446B1783B97DFDB392DA97BD0@orsmsx411.amr.corp.intel.com>
Gross, Mark wrote:
>>Yes, this is what I was talking about. I believe the mode of
>>module_param should be 444, since modifying this after the module is
>>loaded won't do anything. Also, it might be nice to print something
>>different in the "force" case.
>>
>>
>
>How about printing nothing like it used too?
>
>See attached.
>
>
This is fine with me. I debated between printing nothing and a "You
have chosen to override ..." print but didn't come out with any
opinion. I'm easy either way.
The indenting in the "if (!force_function_unhide && !(stat8 & (1 << 5)))
{" clause is kind of strange and you have some spaces instead of tabs
right after that (where stat8 is set).
Thanks again,
-Corey
next prev parent reply other threads:[~2006-04-26 2:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 23:25 Problems with EDAC coexisting with BIOS Gross, Mark
2006-04-26 2:19 ` Corey Minyard [this message]
2006-04-26 2:34 ` Randy.Dunlap
2006-04-26 18:26 ` mark gross
2006-04-26 18:38 ` Randy.Dunlap
2006-04-26 19:39 ` mark gross
2006-04-26 20:17 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2006-05-04 16:44 David Peterson
2006-05-03 23:06 David Peterson
2006-05-03 22:22 Doug Thompson
2006-05-03 21:39 Doug Thompson
2006-05-03 20:49 Gross, Mark
2006-04-26 3:24 Gross, Mark
2006-04-26 3:19 Gross, Mark
2006-04-25 21:24 Gross, Mark
2006-04-25 22:39 ` Corey Minyard
2006-04-25 20:22 Gross, Mark
2006-04-25 18:19 Gross, Mark
2006-04-25 19:55 ` Corey Minyard
2006-04-24 18:14 Gross, Mark
2006-04-24 15:57 Gross, Mark
2006-04-24 17:08 ` Eric W. Biederman
2006-04-24 17:49 ` Alan Cox
2006-04-24 14:32 Ong, Soo Keong
2006-04-24 14:15 Ong, Soo Keong
2006-04-24 14:29 ` Alan Cox
2006-05-03 20:25 ` Tim Small
2006-05-03 20:37 ` thockin
2006-05-04 9:45 ` Tim Small
2006-05-03 21:44 ` Alan Cox
2006-05-04 9:02 ` Tim Small
2006-04-24 13:59 Ong, Soo Keong
2006-04-24 14:13 ` Alan Cox
2006-04-23 1:44 Gross, Mark
2006-04-21 22:36 Doug Thompson
2006-04-21 22:20 Gross, Mark
2006-04-22 18:31 ` Tim Small
2006-04-21 21:42 Doug Thompson
2006-04-21 21:32 Gross, Mark
2006-04-21 20:57 Doug Thompson
2006-04-21 16:01 Gross, Mark
2006-04-21 21:13 ` Ingo Oeser
2006-04-24 13:19 ` Alan Cox
2006-04-24 17:38 ` Doug Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444ED89D.8020405@acm.org \
--to=minyard@acm.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=soo.keong.ong@intel.com \
--cc=steven.carbonari@intel.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.