Re: getfscreatecon(3)

[Daniel J Walsh <dwalsh@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Stephen Smalley wrote:
> On Wed, 2006-04-26 at 13:37 +1000, Russell Coker wrote:
>   
>> RETURN VALUE
>>        On error -1 is returned.
>>
>>        On success getfscreatecon  returns  the  length  of  the  context  (not
>>        including  the  trailing zero byte).  On success setfscreatecon returns
>>        0.
>>
>>
>> Currently getfscreatecon() returns 0 on success.  Should we change the man 
>> page or change the library?
>>
>> I think that it would be best to change the library.
>>     
>
> The man page should be fixed.  Or you'd have to change all of the
> process-oriented get*con functions.  As the string is NUL-terminated,
> you don't need the length.
>
>   


[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 667 bytes --]

diff --exclude-from=exclude -N -u -r nsalibselinux/man/man3/getfscreatecon.3 libselinux-1.30.3/man/man3/getfscreatecon.3
--- nsalibselinux/man/man3/getfscreatecon.3	2004-05-20 11:32:44.000000000 -0400
+++ libselinux-1.30.3/man/man3/getfscreatecon.3	2006-04-26 08:10:37.000000000 -0400
@@ -32,9 +32,7 @@
 save, reset, and restore the fscreate context to avoid unexpected behaviors.
 .SH "RETURN VALUE"
 On error -1 is returned.
-
-On success getfscreatecon returns the length of the context (not including
-the trailing zero byte).  On success setfscreatecon returns 0.
+On success 0 is returned.
 
 .SH "SEE ALSO"
 .BR freecon "(3), " getcon "(3), " getexeccon "(3)"