Re: [H.323 Helper 1/3]: Add support for Call Forwarding

[Patrick McHardy <kaber@trash.net>]

Jing Min Zhao wrote:
> This patch is for 2.6.17-rc2. Please visit
> http://nath323.sourceforge.net/#_Toc133598071 for details.
> 
> Signed-off-by: Jing Min Zhao <zhaojingmin@users.sourceforge.net>

Please attach patches inline so I can view and quote them in my mail
client and include the patch description with the patch.

As for the patch:

I definitely don't like the internal_net module option. I know its not
strictly required, more an optimization, but still limiting this to only
one network is not a good idea. We may be able to use the routing
information as indication whether we need an expectation or not .. but
I need think about it some more.


--- a/include/linux/netfilter_ipv4/ip_conntrack.h
+++ b/include/linux/netfilter_ipv4/ip_conntrack.h
@@ -154,6 +154,7 @@ struct ip_conntrack_expect
        unsigned int flags;

 #ifdef CONFIG_IP_NF_NAT_NEEDED
+       u_int32_t saved_ip;
        /* This is the original per-proto part, used to map the
         * expected connection the way the recipient expects. */
        union ip_conntrack_manip_proto saved_proto;

Please explain why this is needed.