From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: Re: Licensing conflict with OpenAFS kernel module Date: Wed, 26 Apr 2006 11:29:47 -0500 Message-ID: <444F9FFB.8080602@us.ibm.com> References: <20060426140707.GA6094@cheesecake.org> <444F916E.10809@us.ibm.com> <20060426153332.GA32624@cheesecake.org> <444F9405.9010108@us.ibm.com> <20060426155118.GA358@cheesecake.org> <4a1ffa39e3cca91b2c5263452ea571ed@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4a1ffa39e3cca91b2c5263452ea571ed@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Sidney Cammeresi List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > > On 26 Apr 2006, at 16:51, Sidney Cammeresi wrote: > >>> I'd suggest bringing this up within the OpenAFS community. If they are >>> making direct use of Xen-specific functions, then they can potentially >>> find a work around. >>> >>> If we've made it so that a non-GPL symbol depends on one of our GPL'd >>> symbols, then that may be a problem on our part. I don't know whether >>> this is an acceptable thing to do. Sounds like an issue that needs to >>> be discussed on LKML. >> >> These functions do not appear in the OpenAFS source code, so the latter >> possibility seems more likely. I made some cursory examinations of the >> source trees, but not knowing a lot about either, I didn't find >> anything. >> If there's something I can do to help (like sending over my compiled >> kernel module), let me know. > > Those symbols are used by some extremely primitive and ubiquitous > kernel macros (e.g., local_irq_enable(), local_irq_restore(), > pagetable macros, page_to_phys(), ...). > > I think the obvious course of action is to make those two > EXPORT_SYMBOL() and add a comment to explain why. There's not exactly > a lot of GPL'ed goodness hidden behind them! Agreed, and in general, my suspicion is that for upstream merge, we have to make sure that we're not changing the license constraints of any existing EXPORT_SYMBOL(). Regards, Anthony Liguori > -- Keir >