All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henne <henne@nachtwindheim.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] This was the last of my pci __devinitdata patches!
Date: Wed, 26 Apr 2006 20:18:54 +0000	[thread overview]
Message-ID: <444FD5AE.6050101@nachtwindheim.de> (raw)

So, this was the first set of my patches. :)
Things I learned:
-	The default linelength of thunderbird (72 chars) are not enough for patches and configuring the mailclient can save a lot of time.

-	There are many pci-drivers which are not conform in all points to
	<kernel>/Documentation/pci.txt
  	e.g. : if the remove funcion of the driver is marked as __devexit,
		the __devexit_p() is forgotten in struct pci_driver,
		which can leave a pointer to a function which doesn't exist. (evil)

-	Bringing more ifdefs into the kernel is evil too.

-	Typing 286 (what a number) times "__devinitdata" could have benn much more boring.

Questions I have:

-	What is the prefered way to make powemanagement-stuff depend on CONFIG_PM?
	ifdef the .suspend and .resume in struct pci_driver and gather these functions into ONE
	#ifdef CONFIG_PM
	#endif
	?
	There are lots of drivers who have there PM-functions compiled, even if no CONFIG_PM is set.

-	Will these patches be put into the mainline-kernel by you or must every janitor send them
	again to the subsys-maintainer?

Greets,
Henne
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2006-04-26 20:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26 20:18 Henne [this message]
2006-04-26 21:03 ` [KJ] This was the last of my pci __devinitdata patches! Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=444FD5AE.6050101@nachtwindheim.de \
    --to=henne@nachtwindheim.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.