From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, T-Bone@parisc-linux.org,
grundler@parisc-linux.org, jgarzik@pobox.com,
varenet@parisc-linux.org, Francois Romieu <romieu@fr.zoreil.com>
Subject: Re: [patch 2/9] tulip: NatSemi DP83840A PHY fix
Date: Thu, 27 Apr 2006 05:52:55 -0400 [thread overview]
Message-ID: <44509477.4010001@garzik.org> (raw)
In-Reply-To: <200604270932.k3R9W4Xj025312@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> + if (startup) {
> + int timeout = 10; /* max 1 ms */
> for (i = 0; i < reset_length; i++)
> iowrite32(get_u16(&reset_sequence[i]) << 16, ioaddr + CSR15);
> +
> + /* flush posted writes */
> + ioread32(ioaddr + CSR15);
> +
> + /* Sect 3.10.3 in DP83840A.pdf (p39) */
> + udelay(500);
> +
> + /* Section 4.2 in DP83840A.pdf (p43) */
> + /* and IEEE 802.3 "22.2.4.1.1 Reset" */
> + while (timeout-- &&
> + (tulip_mdio_read (dev, phy_num, MII_BMCR) & BMCR_RESET))
> + udelay(100);
What can we do about this?
Its a huge delay to be taken inside a spinlock.
Anybody interested to converting the driver to use schedule_work() or
similar?
Jeff
next prev parent reply other threads:[~2006-04-27 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 9:30 [patch 2/9] tulip: NatSemi DP83840A PHY fix akpm
2006-04-27 9:52 ` Jeff Garzik [this message]
2006-04-27 10:21 ` Thibaut VARENE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44509477.4010001@garzik.org \
--to=jeff@garzik.org \
--cc=T-Bone@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=grundler@parisc-linux.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=varenet@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.