From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, ioe-lkml@rameria.de, manfred@colorfullife.com
Subject: Re: [patch 8/9] forcedeth: suggested cleanups
Date: Thu, 27 Apr 2006 05:56:49 -0400 [thread overview]
Message-ID: <44509561.3090006@garzik.org> (raw)
In-Reply-To: <200604270932.k3R9WD14025332@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> From: Ingo Oeser <ioe-lkml@rameria.de>
>
> general:
> - endian annotation of the ring descriptors
>
> nv_getlen():
> - use htons() instead of __constant_htons()
> to improvde readability and let the compiler constant fold it.
>
> nv_rx_process():
> - use a real for() loop in processing instead of goto and break
> - consolidate rx_errors increment
> - count detected rx_length_errors
>
> Signed-off-by: Ingo Oeser <ioe-lkml@rameria.de>
> Cc: Manfred Spraul <manfred@colorfullife.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
ACK, but I'm holding off applying this while trying to get 4 apply-able
patches out of NVIDIA and Manfred :)
Jeff
prev parent reply other threads:[~2006-04-27 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 9:30 [patch 8/9] forcedeth: suggested cleanups akpm
2006-04-27 9:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44509561.3090006@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=ioe-lkml@rameria.de \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.