All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [patch] PowerPC: Removed duplicate query..
Date: Thu, 27 Apr 2006 22:18:05 +0300	[thread overview]
Message-ID: <445118ED.5010509@nic.fi> (raw)

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Hi,

I was looking at PowerPC's kernel code at one point and noticed that
"/chosen" is queried multiple times. This message contains attachment
removing this duplication.

Thanks,
Vesa Jääskeläinen

[-- Attachment #2: powerpc.diff --]
[-- Type: text/plain, Size: 1369 bytes --]

Index: ChangeLog
===================================================================
RCS file: /sources/grub/grub2/ChangeLog,v
retrieving revision 1.248
diff -u -r1.248 ChangeLog
--- ChangeLog	26 Apr 2006 21:58:35 -0000	1.248
+++ ChangeLog	27 Apr 2006 19:08:39 -0000
@@ -1,3 +1,8 @@
+2006-04-27  Vesa Jaaskelainen  <chaac@nic.fi>
+
+	* kern/powerpc/ieee1275/init.c (grub_machine_init): Removed
+	duplicated query for IEEE-1275's "/chosen".
+
 2006-04-26  Yoshinori K. Okuji  <okuji@enbug.org>
 
 	* util/i386/pc/grub-mkimage.c (compress_kernel): Cast arguments
Index: kern/powerpc/ieee1275/init.c
===================================================================
RCS file: /sources/grub/grub2/kern/powerpc/ieee1275/init.c,v
retrieving revision 1.25
diff -u -r1.25 init.c
--- kern/powerpc/ieee1275/init.c	26 Apr 2006 02:20:12 -0000	1.25
+++ kern/powerpc/ieee1275/init.c	27 Apr 2006 19:08:39 -0000
@@ -116,7 +116,6 @@
 grub_machine_init (void)
 {
   char args[256];
-  grub_ieee1275_phandle_t chosen;
   int actual;
   extern char _start;
 
@@ -137,8 +136,7 @@
   grub_ofdisk_init ();
 
   /* Process commandline.  */
-  grub_ieee1275_finddevice ("/chosen", &chosen);
-  if (grub_ieee1275_get_property (chosen, "bootargs", &args,
+  if (grub_ieee1275_get_property (grub_ieee1275_chosen, "bootargs", &args,
 				  sizeof args, &actual) == 0
       && actual > 1)
     {

                 reply	other threads:[~2006-04-27 19:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445118ED.5010509@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.