All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Massimiliano Hofer <max@nucleus.it>, netfilter-devel@lists.netfilter.org
Subject: Re: condition for 2.6.16
Date: Fri, 28 Apr 2006 15:07:26 +0200	[thread overview]
Message-ID: <4452138E.7050402@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0604281455520.20380@blackhole.kfki.hu>

Jozsef Kadlecsik wrote:
> On Fri, 28 Apr 2006, Massimiliano Hofer wrote:
> 
> 
>>>How would you achieve O(1) average?
>>
>>Hash. But it adds complexity to the code and unnecessary complexity is a form
>>of ugliness.
> 
> 
> Why don't you choose an array and its indices? Array size could be
> specified by module parameter if the default were not sufficient for
> someone.

I just removed something similar from the nth match :) It used a
hard-coded size, but either way I don't like introducing this
limitation just to work around the small uglyness required to
keep a pointer inside the per-instance match data. We already
have multiple precedents for this.

  reply	other threads:[~2006-04-28 13:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 17:19 condition for 2.6.16 Massimiliano Hofer
2006-04-20 18:49 ` Patrick McHardy
2006-04-20 19:39   ` Massimiliano Hofer
2006-04-20 19:44     ` Martijn Lievaart
2006-04-20 22:47     ` Patrick McHardy
2006-04-20 23:26       ` Massimiliano Hofer
2006-04-21  0:41         ` Gerd v. Egidy
2006-04-21  0:48         ` Gerd v. Egidy
2006-04-21  9:29           ` Amin Azez
2006-04-23 13:47   ` Simon Lodal
2006-04-28  7:12     ` Patrick McHardy
2006-04-28 10:46       ` Massimiliano Hofer
2006-04-28 11:06         ` Patrick McHardy
2006-04-28 12:44           ` Massimiliano Hofer
2006-04-28 12:58             ` Jozsef Kadlecsik
2006-04-28 13:07               ` Patrick McHardy [this message]
2006-04-28 15:18                 ` KOVACS Krisztian
2006-04-28 15:34                   ` Patrick McHardy
2006-04-29  0:53                     ` Massimiliano Hofer
2006-04-29  2:56                       ` Patrick McHardy
2006-04-29 15:36                         ` Massimiliano Hofer
2006-04-28 13:18               ` Massimiliano Hofer
2006-04-28 13:09             ` Patrick McHardy
2006-04-28 13:26               ` Massimiliano Hofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4452138E.7050402@trash.net \
    --to=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=max@nucleus.it \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.