From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6827B7A for ; Tue, 15 Mar 2022 18:50:27 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id e22so2680918edc.13 for ; Tue, 15 Mar 2022 11:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=isS1AYQcwVPOcEynJdmCksyBOj5J5k4cGXy9RxN9siM=; b=EJAR8bgpKmAzptXx9PJ1JiXWfZa4MK/+HWdD9If3KRwYbuvcHJuGI23cqy7p1yoRML tW8cZV/UomyHa9mRQI/k3hZkoINAsGKuFcOs0nQQO8GYttIqs9e4RfVUzigKZ/AmLqKt aH6gnqHpIIHuHXG2v5Rjscm7xPDW2OCKzy1J8tCbxxE285qCSPV9rngp6i9a8TAVVvlm PASZUntJ91F3OG07e1StFZGA2A5EKPiqfwsN0xUeYk6WVzmM5DtgKJNVsy/13bKKm3p7 tjM0vwmCWiueiGNu+GUlp+N71G/6RutaybQ0Qwb9e7DrRRfQf2NCSoje3jKCD48pmffa fj7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=isS1AYQcwVPOcEynJdmCksyBOj5J5k4cGXy9RxN9siM=; b=hi2jAk0sRRlCYxTlKMiK71oXXVg0GaSQDHlMlN17OlMVaudqzW5LxXlh59rpz6S7yg 2/TV4kw+FQ9ZbqMH1d9AMCdqF6YtaQ95ErvK7Tc6OlRui5WQ+sJVh8u+cLOb+kLV2v6j kDAgpXj9Tnd9vhXq98i/3DLRN5hTFD6ZRTULf2GrvYPeYX3Ox7Sl5+qvqBH2ZoRm39R2 FLQ4p3qMH0R3k9Drea2yYOkLvIkzmn/CJIEW7Hp3fNHEmuZ4krBpahsNG6M9C7rjS+mf Ep30TSjkT33uOfQjKmpo+BPXYjvOMvnHp8ysKKL/SqTaeE3i9LXCJ1WuvpL/ReHjIFtw 5OTw== X-Gm-Message-State: AOAM533WQIZ3yDLOdMe3IQxvoRpEyjLocxfij+JlYEwt3RMPGfQhr0Ui faDWi+9fIgcqMnnzg7be46f2queYvLw5Ng== X-Google-Smtp-Source: ABdhPJxInX22y59stRqwLhA58e5mYMCN0nEinf10VE+bMfkXFl0cU9SFTmDTCGo59xL2vgPYa8y5ow== X-Received: by 2002:a50:d78e:0:b0:416:2cd7:7ac5 with SMTP id w14-20020a50d78e000000b004162cd77ac5mr26447468edi.320.1647370225554; Tue, 15 Mar 2022 11:50:25 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id f6-20020a0564021e8600b00412ae7fda95sm9970933edf.44.2022.03.15.11.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 11:50:25 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Petr =?utf-8?B?xaB0ZXRpYXI=?= Cc: Petr =?utf-8?B?xaB0ZXRpYXI=?= , stable@vger.kernel.org, Bastien =?ISO-8859-1?Q?Roucari=E8s?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Date: Tue, 15 Mar 2022 19:50:23 +0100 Message-ID: <44524634.fMDQidcC6G@kista> In-Reply-To: <20220315095244.29718-2-ynezz@true.cz> References: <20220315095244.29718-1-ynezz@true.cz> <20220315095244.29718-2-ynezz@true.cz> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Hi Petr! Dne torek, 15. marec 2022 ob 10:52:42 CET je Petr =C5=A0tetiar napisal(a): > This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it > breaks network on my A20-olinuxino-lime2 hardware revision "K" which has > Micrel KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous > hardware revisions which were based on RTL8211E-VB-CG1 PHY and thus this > fix was working on his board. NAK. As Corentin mentioned in another discussion, new DT variant should be=20 introduced for newer board model. Otherwise we can play this revert game wi= th=20 each new revision which changes Ethernet PHY behaviour. It also makes most= =20 sense to have naming chronologically sorted. If board name in DT file doesn= 't=20 have any postfix, it should be compatible with earliest publicly available= =20 board. If board manufacturer releases new board variant with incompatible=20 changes, new DT with appropriate postfix should be introduced. I understand that this is frustrating for you, but whole situation around=20 mentioned commit is unfortunate and we can't satisfy everyone. Also good way to solve such issues is to apply DT overlay in bootloader bas= ed=20 on board revision number. I know Olimex implemented DT fixup in their=20 downstream U-Boot fork. Best regards, Jernej >=20 > Cc: stable@vger.kernel.org > Cc: Bastien Roucari=C3=A8s > References: https://github.com/openwrt/openwrt/issues/9153 > References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-= OLinuXino-LIME2/hardware_revision_changes_log.txt > Signed-off-by: Petr =C5=A0tetiar > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/b= oot/ dts/sun7i-a20-olinuxino-lime2.dts > index ecb91fb899ff..8077f1716fbc 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -112,7 +112,7 @@ &gmac { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&gmac_rgmii_pins>; > phy-handle =3D <&phy1>; > - phy-mode =3D "rgmii-id"; > + phy-mode =3D "rgmii"; > status =3D "okay"; > }; > =20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECF3EC433F5 for ; Tue, 15 Mar 2022 18:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IDUrBvnu28v2w6BcLNsZ8PQYE/ZB8Ol7l9limthLCbg=; b=wo0oPxxP+gUL7R nj9+1Su37XFnqneL7QHfSdFkd1JgY8MK+BTZZonnNzC/enjyszoCnaaYTcIm2u00EaheV8fbPNe2W mHFslIQYlIgM2pfK3vFjgC0FsArEWHDGqM7VVLSA+4BCUGmYwocXmV+lzjjpDN69TUuXMkwKlAV/w Mtao2hh3VLYch5jMxEQwvkmiRDmc8+Yk8y/5Ci9eNAUqi0kBbEXnOtr0A3Rq3UXmFuXPtC96mivpU OZxGqULcV2pYrvckAcqg2BJsvATlEBnap8ZAYUZoOm1/pb9j4z9TgdfAHqn2RkuKuAhdva5OG3kEj 8tGCnxPPWHtTdHaUtvYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUCFa-00ALqL-PC; Tue, 15 Mar 2022 18:50:31 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUCFX-00ALpc-19 for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 18:50:28 +0000 Received: by mail-ed1-x52f.google.com with SMTP id h13so17701ede.5 for ; Tue, 15 Mar 2022 11:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=isS1AYQcwVPOcEynJdmCksyBOj5J5k4cGXy9RxN9siM=; b=EJAR8bgpKmAzptXx9PJ1JiXWfZa4MK/+HWdD9If3KRwYbuvcHJuGI23cqy7p1yoRML tW8cZV/UomyHa9mRQI/k3hZkoINAsGKuFcOs0nQQO8GYttIqs9e4RfVUzigKZ/AmLqKt aH6gnqHpIIHuHXG2v5Rjscm7xPDW2OCKzy1J8tCbxxE285qCSPV9rngp6i9a8TAVVvlm PASZUntJ91F3OG07e1StFZGA2A5EKPiqfwsN0xUeYk6WVzmM5DtgKJNVsy/13bKKm3p7 tjM0vwmCWiueiGNu+GUlp+N71G/6RutaybQ0Qwb9e7DrRRfQf2NCSoje3jKCD48pmffa fj7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=isS1AYQcwVPOcEynJdmCksyBOj5J5k4cGXy9RxN9siM=; b=SkL6KlHQQLdH65RdDApaMHE3pl7y84pgzx+B/qOivU50lJ02OUFxfWlyeQH0rZyBVc hBsuoAFHNaf5qju2qyVGpv55zPdRs78R7pmYSTW83k41cZjzrkjCSdtvu9tKXRV884VL 4iDupuV0+ziHpzvpnKKHFRUkdXkJmiC7eWPvVnBQ9Ki/5H0uz6dC0rFJe1T4GGFy6iDs BByYHCkmN9nCTzJ+GmPysbGgp+ZanhW2htyGqcT4yagATDlDLZnMG6o0E0zcIIwN8U7h F2ZMnLzC7zBCALW6bWOquUkoVe1gdFI84R6uLe9ywcjw+wvTeyhTa+mhDBhGYzV6M+2E NMEQ== X-Gm-Message-State: AOAM530zlk4cNfU/Z+L3fAKZH9zDDDPgCaWO4ijh7R1Ytb40R7THqcyN 8GqiDYKY+hES+j8rW0+0hiE= X-Google-Smtp-Source: ABdhPJxInX22y59stRqwLhA58e5mYMCN0nEinf10VE+bMfkXFl0cU9SFTmDTCGo59xL2vgPYa8y5ow== X-Received: by 2002:a50:d78e:0:b0:416:2cd7:7ac5 with SMTP id w14-20020a50d78e000000b004162cd77ac5mr26447468edi.320.1647370225554; Tue, 15 Mar 2022 11:50:25 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id f6-20020a0564021e8600b00412ae7fda95sm9970933edf.44.2022.03.15.11.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 11:50:25 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Petr =?utf-8?B?xaB0ZXRpYXI=?= Cc: Petr =?utf-8?B?xaB0ZXRpYXI=?= , stable@vger.kernel.org, Bastien =?ISO-8859-1?Q?Roucari=E8s?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Date: Tue, 15 Mar 2022 19:50:23 +0100 Message-ID: <44524634.fMDQidcC6G@kista> In-Reply-To: <20220315095244.29718-2-ynezz@true.cz> References: <20220315095244.29718-1-ynezz@true.cz> <20220315095244.29718-2-ynezz@true.cz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_115027_097827_927CE96D X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGV0ciEKCkRuZSB0b3JlaywgMTUuIG1hcmVjIDIwMjIgb2IgMTA6NTI6NDIgQ0VUIGplIFBl dHIgxaB0ZXRpYXIgbmFwaXNhbChhKToKPiBUaGlzIHJldmVydHMgY29tbWl0IDU1ZGQ3ZTA1OTA5 OGNlNGJkMGE1NWMyNTFjYjc4ZTc0NjA0YWJiNTcgYXMgaXQKPiBicmVha3MgbmV0d29yayBvbiBt eSBBMjAtb2xpbnV4aW5vLWxpbWUyIGhhcmR3YXJlIHJldmlzaW9uICJLIiB3aGljaCBoYXMKPiBN aWNyZWwgS1NaOTAzMVJOWENDLVRSIEdpZ2FiaXQgUEhZLiBCYXN0aWVuIGhhcyBwcm9iYWJseSBz b21lIHByZXZpb3VzCj4gaGFyZHdhcmUgcmV2aXNpb25zIHdoaWNoIHdlcmUgYmFzZWQgb24gUlRM ODIxMUUtVkItQ0cxIFBIWSBhbmQgdGh1cyB0aGlzCj4gZml4IHdhcyB3b3JraW5nIG9uIGhpcyBi b2FyZC4KCk5BSy4KCkFzIENvcmVudGluIG1lbnRpb25lZCBpbiBhbm90aGVyIGRpc2N1c3Npb24s IG5ldyBEVCB2YXJpYW50IHNob3VsZCBiZSAKaW50cm9kdWNlZCBmb3IgbmV3ZXIgYm9hcmQgbW9k ZWwuIE90aGVyd2lzZSB3ZSBjYW4gcGxheSB0aGlzIHJldmVydCBnYW1lIHdpdGggCmVhY2ggbmV3 IHJldmlzaW9uIHdoaWNoIGNoYW5nZXMgRXRoZXJuZXQgUEhZIGJlaGF2aW91ci4gSXQgYWxzbyBt YWtlcyBtb3N0IApzZW5zZSB0byBoYXZlIG5hbWluZyBjaHJvbm9sb2dpY2FsbHkgc29ydGVkLiBJ ZiBib2FyZCBuYW1lIGluIERUIGZpbGUgZG9lc24ndCAKaGF2ZSBhbnkgcG9zdGZpeCwgaXQgc2hv dWxkIGJlIGNvbXBhdGlibGUgd2l0aCBlYXJsaWVzdCBwdWJsaWNseSBhdmFpbGFibGUgCmJvYXJk LiBJZiBib2FyZCBtYW51ZmFjdHVyZXIgcmVsZWFzZXMgbmV3IGJvYXJkIHZhcmlhbnQgd2l0aCBp bmNvbXBhdGlibGUgCmNoYW5nZXMsIG5ldyBEVCB3aXRoIGFwcHJvcHJpYXRlIHBvc3RmaXggc2hv dWxkIGJlIGludHJvZHVjZWQuCgpJIHVuZGVyc3RhbmQgdGhhdCB0aGlzIGlzIGZydXN0cmF0aW5n IGZvciB5b3UsIGJ1dCB3aG9sZSBzaXR1YXRpb24gYXJvdW5kIAptZW50aW9uZWQgY29tbWl0IGlz IHVuZm9ydHVuYXRlIGFuZCB3ZSBjYW4ndCBzYXRpc2Z5IGV2ZXJ5b25lLgoKQWxzbyBnb29kIHdh eSB0byBzb2x2ZSBzdWNoIGlzc3VlcyBpcyB0byBhcHBseSBEVCBvdmVybGF5IGluIGJvb3Rsb2Fk ZXIgYmFzZWQgCm9uIGJvYXJkIHJldmlzaW9uIG51bWJlci4gSSBrbm93IE9saW1leCBpbXBsZW1l bnRlZCBEVCBmaXh1cCBpbiB0aGVpciAKZG93bnN0cmVhbSBVLUJvb3QgZm9yay4KCkJlc3QgcmVn YXJkcywKSmVybmVqCgo+IAo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gQ2M6IEJhc3Rp ZW4gUm91Y2FyacOocyA8cm91Y2FAZGViaWFuLm9yZz4KPiBSZWZlcmVuY2VzOiBodHRwczovL2dp dGh1Yi5jb20vb3BlbndydC9vcGVud3J0L2lzc3Vlcy85MTUzCj4gUmVmZXJlbmNlczogaHR0cHM6 Ly9naXRodWIuY29tL09MSU1FWC9PTElOVVhJTk8vYmxvYi9tYXN0ZXIvSEFSRFdBUkUvQTIwLU9M aW51WGluby1MSU1FMi9oYXJkd2FyZV9yZXZpc2lvbl9jaGFuZ2VzX2xvZy50eHQKPiBTaWduZWQt b2ZmLWJ5OiBQZXRyIMWgdGV0aWFyIDx5bmV6ekB0cnVlLmN6Pgo+IC0tLQo+ICBhcmNoL2FybS9i b290L2R0cy9zdW43aS1hMjAtb2xpbnV4aW5vLWxpbWUyLmR0cyB8IDIgKy0KPiAgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtL2Jvb3QvZHRzL3N1bjdpLWEyMC1vbGludXhpbm8tbGltZTIuZHRzIGIvYXJjaC9hcm0v Ym9vdC8KZHRzL3N1bjdpLWEyMC1vbGludXhpbm8tbGltZTIuZHRzCj4gaW5kZXggZWNiOTFmYjg5 OWZmLi44MDc3ZjE3MTZmYmMgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvc3VuN2kt YTIwLW9saW51eGluby1saW1lMi5kdHMKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9zdW43aS1h MjAtb2xpbnV4aW5vLWxpbWUyLmR0cwo+IEBAIC0xMTIsNyArMTEyLDcgQEAgJmdtYWMgewo+ICAJ cGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiAgCXBpbmN0cmwtMCA9IDwmZ21hY19yZ21paV9w aW5zPjsKPiAgCXBoeS1oYW5kbGUgPSA8JnBoeTE+Owo+IC0JcGh5LW1vZGUgPSAicmdtaWktaWQi Owo+ICsJcGh5LW1vZGUgPSAicmdtaWkiOwo+ICAJc3RhdHVzID0gIm9rYXkiOwo+ICB9Owo+ICAK PiAKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=