Re: [PATCH 3/3] Eleminate HZ from ROSE kernel interfaces

[Bernard Pidoux <pidoux@ccr.jussieu.fr>]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]


Ralf Baechle wrote :

> Index: linux-net.git/net/rose/af_rose.c
> ===================================================================
> --- linux-net.git.orig/net/rose/af_rose.c	2006-04-29 01:54:21.000000000 +0100
> +++ linux-net.git/net/rose/af_rose.c	2006-04-29 11:37:34.000000000 +0100

While patching af_rose.c, would you consider the following patch 
ROSE/FPAC users have introduced a year ago with good success.

73 de Bernard, f6bvp

http://f6bvp.org
http://rose.fpac.free.fr/MINI-HOWTO/
http://rose.fpac.free.fr/MINI-HOWTO-FR/


[-- Attachment #2: af_rose.diff --]
[-- Type: text/x-patch, Size: 716 bytes --]

--- linux/net/rose/af_rose.c.orig	2006-04-30 11:30:48.000000000 +0200
+++ linux/net/rose/af_rose.c	2006-04-30 11:27:35.000000000 +0200
@@ -753,6 +753,7 @@
 
 		rose_insert_socket(sk);		/* Finish the bind */
 	}
+rose_try_next_neigh:
 	rose->dest_addr   = addr->srose_addr;
 	rose->dest_call   = addr->srose_call;
 	rose->rand        = ((long)rose & 0xFFFF) + rose->lci;
@@ -810,6 +811,11 @@
 	}
 
 	if (sk->sk_state != TCP_ESTABLISHED) {
+	/* Try next neighbour */
+		rose->neighbour = rose_get_neigh(&addr->srose_addr, &cause, &diagnostic);
+		if (rose->neighbour)
+			goto rose_try_next_neigh;
+	/* No more neighbour */
 		sock->state = SS_UNCONNECTED;
 		return sock_error(sk);	/* Always set at this point */
 	}