From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D8C4C004D4 for ; Thu, 19 Jan 2023 12:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JedYlimnauTRzbqFa5RY6dO+mxeINyoBaxzzIOzQRd4=; b=BvWE7s9iZYJ+HA I7WiSkUFx2VdFGH9aUDc4B42NN2lgNrE6xgB1W9Ldc0SsWTa6olGAfISvegp8hRUZgadM3ki5jPin 4qm16bzDMCKkEW9BloJj6ZW+DD3QO39mYf7rv6UNFl6eu+IVYLb2FYmWFd7tJpE30uRdkku5/EjJH JVBVh3d1cGO2Q/RripA1s+4cpDzHNu8MNFa5r37mpvf/lBIt4ALZVkjJrzseO7hidLuW29hRiyY5V mjswOZYYVzLgWPvtwyXiEc14yKG0Fp8NabBsYXt+AzY/eq/m/VxQFEue+PeZtwgJi2ORPu/b3X7pH MT1ibDTuL2iLWUwdlsbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pITpo-004mnb-Qp; Thu, 19 Jan 2023 12:16:00 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pITpl-004mmj-OK; Thu, 19 Jan 2023 12:15:59 +0000 Received: from wf0783.dip.tu-dresden.de ([141.76.183.15] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pITpV-0002mO-3s; Thu, 19 Jan 2023 13:15:41 +0100 From: Heiko Stuebner To: Michael Tretter , Nicolas Frattaroli , robh+dt@kernel.org, Peter Geis Cc: Ezequiel Garcia , linux-rockchip@lists.infradead.org, Shengyu Qu , devicetree@vger.kernel.org, jacob-chen@iotwrt.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, michael.riesch@wolfvision.net Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x Date: Thu, 19 Jan 2023 13:15:39 +0100 Message-ID: <4455473.LvFx2qVVIh@phil> In-Reply-To: <5241675.okTXgP3Kn8@archbook> References: <20221121151755.2072816-3-m.tretter@pengutronix.de> <20230117124114.GF23495@pengutronix.de> <5241675.okTXgP3Kn8@archbook> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_041557_817356_D85D7CCF X-CRM114-Status: GOOD ( 49.81 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpBbSBNaXR0d29jaCwgMTguIEphbnVhciAyMDIzLCAwMTowMTo0OCBDRVQgc2NocmllYiBO aWNvbGFzIEZyYXR0YXJvbGk6Cj4gT24gRGllbnN0YWcsIDE3LiBKYW51YXIgMjAyMyAxMzo0MTox NCBDRVQgTWljaGFlbCBUcmV0dGVyIHdyb3RlOgo+ID4gT24gV2VkLCAyMyBOb3YgMjAyMiAxMDoy ODo0MSArMDEwMCwgTWljaGFlbCBUcmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIDIyIE5vdiAy MDIyIDIwOjQ3OjQ5ICswMTAwLCBOaWNvbGFzIEZyYXR0YXJvbGkgd3JvdGU6Cj4gPiA+ID4gT24g RGllbnN0YWcsIDIyLiBOb3ZlbWJlciAyMDIyIDAwOjEwOjI1IENFVCBQZXRlciBHZWlzIHdyb3Rl Ogo+ID4gPiA+ID4gT24gTW9uLCBOb3YgMjEsIDIwMjIgYXQgMTI6MzQgUE0gRXplcXVpZWwgR2Fy Y2lhCj4gPiA+ID4gPiA8ZXplcXVpZWxAdmFuZ3VhcmRpYXN1ci5jb20uYXI+IHdyb3RlOgo+ID4g PiA+ID4gPiBPbiBNb24sIE5vdiAyMSwgMjAyMiBhdCAyOjEzIFBNIFNoZW5neXUgUXUgPHdpYWdu MjMzQG91dGxvb2suY29tPiB3cm90ZToKPiA+ID4gPiA+ID4gPiBJIHJlbWVtYmVyIHNvbWVvbmUg c2FpZCB0aGF0IHJnYTIgaGFzIG9ubHkgMzJiaXQgYWRkcmVzcyBzcGFjZSBidXQgbm90Cj4gPiA+ ID4gPiA+ID4gaGF2aW5nIGEgbW11IG9yIG1tdSBuZWVkcyB0byBiZSBjb25maWd1cmVkLiBCZXR0 ZXIgYXNrIGJ5IHlvdXJzZWxmIGluCj4gPiA+ID4gPiA+ID4gcGluZTY0IGRpc2NvcmQgc2luY2Ug SSdtIG5vdCBzdXJlIGFib3V0IHRoYXQuCj4gPiA+ID4gPiA+ID4g5LqOIDIwMjLlubQxMeaciDIy 5pelIEdNVCswODowMCDkuIrljYgxMjo0MToxNiwgTWljaGFlbCBUcmV0dGVyIDxtLnRyZXR0ZXJA cGVuZ3V0cm9uaXguZGU+IOWGmeWIsDoKPiA+ID4gPiA+ID4gPiA+T24gVHVlLCAyMiBOb3YgMjAy MiAwMDowMToyOCArMDgwMCwgU2hlbmd5dSBRdSB3cm90ZToKPiA+ID4gPiA+ID4gPiA+PiBTb21l b25lIGZyb20gcGluZTY0IGRpc2NvcmQgZm91bmQgdGhhdCBSR0EyIGRvZXNuJ3Qgd29yayBwcm9w ZXJseSBvbiBvdmVyCj4gPiA+ID4gPiA+ID4gPj4KPiA+ID4gPiA+ID4gPiA+PiA0R0IgbWVtb3J5 IFJLMzU2OCBkZXZpY2VzLiBBcmUgeW91IHN1cmUgY3VycmVudCBkcml2ZXIgd29ya3Mgbm93Pwo+ ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+SSBhbSBhYnNvbHV0ZWx5IHN1cmUgdGhhdCB0 aGUgZHJpdmVyIHdvcmtzIG9uIGEgMkdCIFJPQ0szQSBib2FyZC4KPiA+ID4gPiA+ID4gPiA+VW5m b3J0dW5hdGVseSwgSSBkb24ndCBoYXZlIGEgZGV2aWNlIHdpdGggNEdCIG9yIG1vcmUgbWVtb3J5 IGFuZCBJIGNhbm5vdCB0ZXN0Cj4gPiA+ID4gPiA+ID4gPnRoZSBkcml2ZXIgd2l0aCBzdWNoIGEg ZGV2aWNlLgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+QXMgdGhlIGRvY3VtZW50YXRp b24gZm9yIHRoZSBSR0EyIGlzIHRoZSBzYW1lIGluIHRoZSBUUk0gb2YgdGhlIHJrMzI4OCBhbmQK PiA+ID4gPiA+ID4gPiA+cmszNTY4LCBJIHdvdWxkIGd1ZXNzIHRoYXQgdGhlIGRyaXZlciBkb2Vz bid0IHdvcmsgb24gYSByazMyODggd2l0aCBtb3JlIHRoYW4KPiA+ID4gPiA+ID4gPiA+NEdCIChp ZiB0aGVyZSBpcyBzdWNoIGEgdGhpbmcpIGVpdGhlciBhbmQgdGhlIGRyaXZlciBuZWVkcyB0byBi ZSBmaXhlZCBmb3IKPiA+ID4gPiA+ID4gPiA+Ym90aCBTb0NzLgo+ID4gPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gSW4gYW55IGNhc2UsIGlmIHRoZXJlJ3Mgc29tZSBraW5kIG9m IGlzc3VlIGl0IG11c3QgYmUgaW4gdGhlIGRyaXZlciwKPiA+ID4gPiA+ID4gYW5kIG5vdCBpbiB0 aGUgZGV2aWNlIHRyZWUgYmluZGluZyAoaS5lLiB0aGlzIHBhdGNoc2V0KS4KPiA+ID4gPiA+IAo+ ID4gPiA+ID4gQW4gdW5mb3J0dW5hdGUgbnVtYmVyIG9mIFJvY2tjaGlwIGRyaXZlcnMgYnJlYWsg b24gcmszNTZ4IGJvYXJkcyB3aXRoCj4gPiA+ID4gPiBtb3JlIHRoYW4gNEdCIG9mIHJhbS4gSSd2 ZSBmb3VuZCByZXF1ZXN0aW5nIG1lbW9yeSBhbGxvY2F0aW9ucyB3aXRoCj4gPiA+ID4gPiB0aGUg R0ZQX0RNQSBmbGFnIHNvbHZlcyB0aGUgcHJvYmxlbSwgYXMgdGhlIGtlcm5lbCBvbmx5IGFsbG9j YXRlcwo+ID4gPiA+ID4gMzJiaXQgYWRkcmVzc2VzIGZvciBETUEgb24gcmszNTZ4LiBUaGlzIGlz IHNpbWlsYXIgdG8gdGhlIGJ1ZyB3aXRoIHRoZQo+ID4gPiA+ID4gSVRTIE1TSSBhbGxvY2F0aW9u cy4KPiA+ID4gPiAKPiA+ID4gPiB0aGUgcHJvYmxlbSBpbiB0aGlzIGNhc2UgYXQgbGVhc3QgcGFy dGx5IHNlZW1zIHRvIGJlIGRvd24gdG8gdGhlIGRyaXZlcgo+ID4gPiA+IGFzc3VtaW5nIDMyIGJp dCBhZGRyZXNzZXMsIHNlZSBlLmcuIFsxXSAoaWYgSSB1bmRlcnN0YW5kIHRoZSBjb2RlCj4gPiA+ ID4gY29ycmVjdGx5KSBhbmQgWzJdLiBXaGVuIEkgYXNrZWQgaW4gdGhlICNhcm1saW51eCBJUkMg b24gTGliZXJhLmNoYXQKPiA+ID4gPiBhYm91dCB0aGlzLCBSb2JpbiBNdXJwaHkgcmVtYXJrZWQ6 Cj4gPiA+ID4gCj4gPiA+ID4gICA8cm9ibXVyMDE+IHllZXNoLCB0aGUgdmlydF90b19waHlzL2Rt YV9zeW5jIGFidXNlIGlzIGV2ZW4gd29yc2UKPiA+ID4gPiAgIC0gaW4gdGhhdCBwYXJ0aWN1bGFy IGluc3RhbmNlIEknZCBiZSBpbmNsaW5lZCB0byByZXBsYWNlCj4gPiA+ID4gICB7c3JjLGRzdH1f bW11X3BhZ2VzIHdpdGggcHJvcGVyIGNvaGVyZW50IERNQSBidWZmZXJzCj4gPiA+ID4gCj4gPiA+ ID4gU28gdGhlIGRyaXZlciBpbiBnZW5lcmFsIG5lZWRzIHNvbWUgY2xlYW51cCwgd2hpY2ggY29u dHJpYnV0ZXMgdG8gdGhlCj4gPiA+ID4gcHJvYmxlbS4KPiA+ID4gCj4gPiA+IEFzIGZhciBhcyBJ IHVuZGVyc3RhbmQgdGhlIDRHQiBhcmUgYSBoYXJkd2FyZSBsaW1pdGF0aW9uLgo+ID4gPiAKPiA+ ID4gQWNjb3JkaW5nIHRvIHRoZSByazM1NjggVFJNLCB0aGUgUkdBMl9NTVVfU1JDX0JBU0UgaGFz IDI4IGJpdHMgZm9yIHRoZSB1cHBlcgo+ID4gPiAyOCBiaXRzIG9mIHRoZSBhZGRyZXNzIG9mIHRo ZSBNTVUgVExCLiBUaHVzIHRoZSBNTVUgVExCIG11c3QgYmUgbG9jYXRlZCB3aXRoaW4KPiA+ID4g NEdCIG1lbW9yeS4KPiA+ID4gCj4gPiA+IEFuZCB3aXRoaW4gdGhlIE1NVSBUTEIsIHRoZSBhZGRy ZXNzZXMgYXJlIDMyIGJpdCBhcyB3ZWxsICh1bmxlc3MgSSBhbSBtaXNzaW5nCj4gPiA+IHNvbWV0 aGluZyBpbXBvcnRhbnQpLiBVbmZvcnR1bmF0ZWx5LCBJIGNvdWxkbid0IGZpbmQgYW55IGRvY3Vt ZW50YXRpb24gZm9yIHRoZQo+ID4gPiBUTEIuIFRoZSBkb3duc3RyZWFtIGRyaXZlciB3cml0ZXMg b25seSAzMiBiaXQgYWRkcmVzc2VzIHRvIHRoZSBUTEIgYXMgd2VsbC4KPiA+ID4gVGh1cywgSSBh c3N1bWUgdGhhdCBhbGwgdmlkZW8gYnVmZmVycyBtdXN0IGJlIGxvY2F0ZWQgd2l0aGluIDRHQiBt ZW1vcnksIHRvby4KPiA+ID4gCj4gPiA+IFdoaWxlIEkgYWdyZWUgdGhhdCB0aGUgZHJpdmVyIG5l ZWRzIHNvbWUgY2xlYW51cCBhbmQgbWF5IHVzZSBjb3JyZWN0IHR5cGVzIGZvcgo+ID4gPiBoYW5k bGluZyB0aGUgYml0IHNpemUgbGltaXRhdGlvbiwgSSB0aGluayB0aGlzIGlzbid0IHNvbWUgZHJp dmVyIGxpbWl0YXRpb24uCj4gPiA+IE1heWJlIHRoZSBkcml2ZXIgc2hvdWxkIHNldCB0aGUgZG1h IG1hc2sgdG8gMzIgYml0cyBhbmQgc2hvdWxkIGJlIGV4cGxpY2l0bHkKPiA+ID4gYXdhcmUgb2Yg dGhlIDMyIGJpdCBsaW1pdC4KPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gQnV0IGFzIHdhcyBzYWlk LCB0aGlzIGlzbid0IGEgcHJvYmxlbSB3aXRoIHRoZSBkZXZpY2UgdHJlZSwgc28gaXQgc2hvdWxk Cj4gPiA+ID4gc3RpbGwgbWFrZSBpdCBpbi4gSXQganVzdCBtZWFucyB0aGF0IHRoZSBkcml2ZXIg aXMgYnJva2VuIG9uIDhHQiBSSzM1NnguCj4gPiAKPiA+IE5pY29sYXM6IElzIHRoaXMgeW91ciBB Y2tlZC1CeT8KPiA+IAo+ID4gV2hvIHdvdWxkIHBpY2sgdXAgdGhlIHBhdGNoPyBIZWlrbz8KPiA+ IAo+ID4gTWljaGFlbAo+ID4gCj4gCj4gU3VyZSwKPiAKPiBBY2tlZC1ieTogTmljb2xhcyBGcmF0 dGFyb2xpIDxmcmF0dGFyb2xpLm5pY29sYXNAZ21haWwuY29tPgo+IAo+IFRob3VnaCBJJ20gbm90 IHN1cmUgaG93IG11Y2ggd2VpZ2h0IG15IEFja2VkLWJ5IGNhcnJpZXMgaGVyZS4KPiAKPiBGb3Ig YXBwbHlpbmcgdGhlIHBhdGNoLCB5ZXMgdGhhdCB3b3VsZCBiZSBkb25lIGJ5IEhlaWtvLgoKSG1t LCBub3JtYWxseSB0aGUgYmluZGluZyBnb2VzIHRocm91Z2ggdGhlIHJlbGV2YW50IHN1YnN5c3Rl bSB0cmVlCihtZWRpYSBpbiB0aGlzIGNhc2UpLCBhZnRlciB3aGljaCBJJ2Qgbm9ybWFsbHkgcGlj ayB0aGUgZHRzIHBhdGNoLgpNZWRpYSBpcyBhbHdheXMgcHJldHR5IGhhcmQsIGFzIG9uZSBuZXZl ciByZWFsbHkga25vd3MgaWYgYW5kIHdoZW4gc2FpZApwYXRjaGVzIGdldCBhcHBsaWVkLgoKSSBk b24ndCByZWFsbHkgc2VlIG1lZGlhLXBlb3BsZSBpbiB0aGUgQ2MgbGlzdCBhcyB3ZWxsLCBzbyBk b24ndApyZWFsbHkga25vdyB3aGF0J3MgdGhlIHBsYW4uCgpJIGd1ZXNzIHlvdSBtaWdodCB3YW50 IHRvIHJlc2VuZCB3aXRoIFJldmlld3MgYXBwZW5kZWQgYW5kIGluY2x1ZGUKdGhlIG1lZGlhIHBl b3BsZSArIGxpc3QgZm9yIHRoZSBiaW5kaW5nLiAoT3IgSSdkIG5lZWQgYW4gQWNrIGZyb20Kc29t ZW9uZSBmcm9tIG1lZGlhIGZvciBtZSB0byB0YWtlIHRoZSBiaW5kaW5nKQoKCkhlaWtvCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tj aGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2036AC46467 for ; Thu, 19 Jan 2023 12:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nag3te8df3wBAeeMgwcxE2cx85xllI0bk0ZzIcpkcPM=; b=SB98u0Bt0i1MID OXqiISVXUC/xWh7KJIwd1ZeHJ+Iuw0+KbGojyIytSnPzMbuw3YM/etiEsRVQLG6strrzf7XsIZUlO uW+iwmBGIHlCetrzUgKkfAaN8oGruJZmYtTsEkTlOL4GpZO7rmb3RPePf+jRSj1Y53MhY/aQJY+2e hRAcIXQ1M8aHKqLtnCPqrVI7GW/PoKwvFg9nPzrFIWJeTrRZnUpG2MGCb0wax3+7SdhXWAUI7j8NW Cp5YFJdnii/9kVyqSpLsZcD5GHWC+CVhvfEsCzs1ARcLYc8zitnRuPHe5aJS0w6vRgsDpZu7QpWop KlAiTIeGgOBoJdo1q2QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pITpp-004mnf-OD; Thu, 19 Jan 2023 12:16:01 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pITpl-004mmj-OK; Thu, 19 Jan 2023 12:15:59 +0000 Received: from wf0783.dip.tu-dresden.de ([141.76.183.15] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pITpV-0002mO-3s; Thu, 19 Jan 2023 13:15:41 +0100 From: Heiko Stuebner To: Michael Tretter , Nicolas Frattaroli , robh+dt@kernel.org, Peter Geis Cc: Ezequiel Garcia , linux-rockchip@lists.infradead.org, Shengyu Qu , devicetree@vger.kernel.org, jacob-chen@iotwrt.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, michael.riesch@wolfvision.net Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x Date: Thu, 19 Jan 2023 13:15:39 +0100 Message-ID: <4455473.LvFx2qVVIh@phil> In-Reply-To: <5241675.okTXgP3Kn8@archbook> References: <20221121151755.2072816-3-m.tretter@pengutronix.de> <20230117124114.GF23495@pengutronix.de> <5241675.okTXgP3Kn8@archbook> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_041557_817356_D85D7CCF X-CRM114-Status: GOOD ( 49.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpBbSBNaXR0d29jaCwgMTguIEphbnVhciAyMDIzLCAwMTowMTo0OCBDRVQgc2NocmllYiBO aWNvbGFzIEZyYXR0YXJvbGk6Cj4gT24gRGllbnN0YWcsIDE3LiBKYW51YXIgMjAyMyAxMzo0MTox NCBDRVQgTWljaGFlbCBUcmV0dGVyIHdyb3RlOgo+ID4gT24gV2VkLCAyMyBOb3YgMjAyMiAxMDoy ODo0MSArMDEwMCwgTWljaGFlbCBUcmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIDIyIE5vdiAy MDIyIDIwOjQ3OjQ5ICswMTAwLCBOaWNvbGFzIEZyYXR0YXJvbGkgd3JvdGU6Cj4gPiA+ID4gT24g RGllbnN0YWcsIDIyLiBOb3ZlbWJlciAyMDIyIDAwOjEwOjI1IENFVCBQZXRlciBHZWlzIHdyb3Rl Ogo+ID4gPiA+ID4gT24gTW9uLCBOb3YgMjEsIDIwMjIgYXQgMTI6MzQgUE0gRXplcXVpZWwgR2Fy Y2lhCj4gPiA+ID4gPiA8ZXplcXVpZWxAdmFuZ3VhcmRpYXN1ci5jb20uYXI+IHdyb3RlOgo+ID4g PiA+ID4gPiBPbiBNb24sIE5vdiAyMSwgMjAyMiBhdCAyOjEzIFBNIFNoZW5neXUgUXUgPHdpYWdu MjMzQG91dGxvb2suY29tPiB3cm90ZToKPiA+ID4gPiA+ID4gPiBJIHJlbWVtYmVyIHNvbWVvbmUg c2FpZCB0aGF0IHJnYTIgaGFzIG9ubHkgMzJiaXQgYWRkcmVzcyBzcGFjZSBidXQgbm90Cj4gPiA+ ID4gPiA+ID4gaGF2aW5nIGEgbW11IG9yIG1tdSBuZWVkcyB0byBiZSBjb25maWd1cmVkLiBCZXR0 ZXIgYXNrIGJ5IHlvdXJzZWxmIGluCj4gPiA+ID4gPiA+ID4gcGluZTY0IGRpc2NvcmQgc2luY2Ug SSdtIG5vdCBzdXJlIGFib3V0IHRoYXQuCj4gPiA+ID4gPiA+ID4g5LqOIDIwMjLlubQxMeaciDIy 5pelIEdNVCswODowMCDkuIrljYgxMjo0MToxNiwgTWljaGFlbCBUcmV0dGVyIDxtLnRyZXR0ZXJA cGVuZ3V0cm9uaXguZGU+IOWGmeWIsDoKPiA+ID4gPiA+ID4gPiA+T24gVHVlLCAyMiBOb3YgMjAy MiAwMDowMToyOCArMDgwMCwgU2hlbmd5dSBRdSB3cm90ZToKPiA+ID4gPiA+ID4gPiA+PiBTb21l b25lIGZyb20gcGluZTY0IGRpc2NvcmQgZm91bmQgdGhhdCBSR0EyIGRvZXNuJ3Qgd29yayBwcm9w ZXJseSBvbiBvdmVyCj4gPiA+ID4gPiA+ID4gPj4KPiA+ID4gPiA+ID4gPiA+PiA0R0IgbWVtb3J5 IFJLMzU2OCBkZXZpY2VzLiBBcmUgeW91IHN1cmUgY3VycmVudCBkcml2ZXIgd29ya3Mgbm93Pwo+ ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+SSBhbSBhYnNvbHV0ZWx5IHN1cmUgdGhhdCB0 aGUgZHJpdmVyIHdvcmtzIG9uIGEgMkdCIFJPQ0szQSBib2FyZC4KPiA+ID4gPiA+ID4gPiA+VW5m b3J0dW5hdGVseSwgSSBkb24ndCBoYXZlIGEgZGV2aWNlIHdpdGggNEdCIG9yIG1vcmUgbWVtb3J5 IGFuZCBJIGNhbm5vdCB0ZXN0Cj4gPiA+ID4gPiA+ID4gPnRoZSBkcml2ZXIgd2l0aCBzdWNoIGEg ZGV2aWNlLgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+QXMgdGhlIGRvY3VtZW50YXRp b24gZm9yIHRoZSBSR0EyIGlzIHRoZSBzYW1lIGluIHRoZSBUUk0gb2YgdGhlIHJrMzI4OCBhbmQK PiA+ID4gPiA+ID4gPiA+cmszNTY4LCBJIHdvdWxkIGd1ZXNzIHRoYXQgdGhlIGRyaXZlciBkb2Vz bid0IHdvcmsgb24gYSByazMyODggd2l0aCBtb3JlIHRoYW4KPiA+ID4gPiA+ID4gPiA+NEdCIChp ZiB0aGVyZSBpcyBzdWNoIGEgdGhpbmcpIGVpdGhlciBhbmQgdGhlIGRyaXZlciBuZWVkcyB0byBi ZSBmaXhlZCBmb3IKPiA+ID4gPiA+ID4gPiA+Ym90aCBTb0NzLgo+ID4gPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gSW4gYW55IGNhc2UsIGlmIHRoZXJlJ3Mgc29tZSBraW5kIG9m IGlzc3VlIGl0IG11c3QgYmUgaW4gdGhlIGRyaXZlciwKPiA+ID4gPiA+ID4gYW5kIG5vdCBpbiB0 aGUgZGV2aWNlIHRyZWUgYmluZGluZyAoaS5lLiB0aGlzIHBhdGNoc2V0KS4KPiA+ID4gPiA+IAo+ ID4gPiA+ID4gQW4gdW5mb3J0dW5hdGUgbnVtYmVyIG9mIFJvY2tjaGlwIGRyaXZlcnMgYnJlYWsg b24gcmszNTZ4IGJvYXJkcyB3aXRoCj4gPiA+ID4gPiBtb3JlIHRoYW4gNEdCIG9mIHJhbS4gSSd2 ZSBmb3VuZCByZXF1ZXN0aW5nIG1lbW9yeSBhbGxvY2F0aW9ucyB3aXRoCj4gPiA+ID4gPiB0aGUg R0ZQX0RNQSBmbGFnIHNvbHZlcyB0aGUgcHJvYmxlbSwgYXMgdGhlIGtlcm5lbCBvbmx5IGFsbG9j YXRlcwo+ID4gPiA+ID4gMzJiaXQgYWRkcmVzc2VzIGZvciBETUEgb24gcmszNTZ4LiBUaGlzIGlz IHNpbWlsYXIgdG8gdGhlIGJ1ZyB3aXRoIHRoZQo+ID4gPiA+ID4gSVRTIE1TSSBhbGxvY2F0aW9u cy4KPiA+ID4gPiAKPiA+ID4gPiB0aGUgcHJvYmxlbSBpbiB0aGlzIGNhc2UgYXQgbGVhc3QgcGFy dGx5IHNlZW1zIHRvIGJlIGRvd24gdG8gdGhlIGRyaXZlcgo+ID4gPiA+IGFzc3VtaW5nIDMyIGJp dCBhZGRyZXNzZXMsIHNlZSBlLmcuIFsxXSAoaWYgSSB1bmRlcnN0YW5kIHRoZSBjb2RlCj4gPiA+ ID4gY29ycmVjdGx5KSBhbmQgWzJdLiBXaGVuIEkgYXNrZWQgaW4gdGhlICNhcm1saW51eCBJUkMg b24gTGliZXJhLmNoYXQKPiA+ID4gPiBhYm91dCB0aGlzLCBSb2JpbiBNdXJwaHkgcmVtYXJrZWQ6 Cj4gPiA+ID4gCj4gPiA+ID4gICA8cm9ibXVyMDE+IHllZXNoLCB0aGUgdmlydF90b19waHlzL2Rt YV9zeW5jIGFidXNlIGlzIGV2ZW4gd29yc2UKPiA+ID4gPiAgIC0gaW4gdGhhdCBwYXJ0aWN1bGFy IGluc3RhbmNlIEknZCBiZSBpbmNsaW5lZCB0byByZXBsYWNlCj4gPiA+ID4gICB7c3JjLGRzdH1f bW11X3BhZ2VzIHdpdGggcHJvcGVyIGNvaGVyZW50IERNQSBidWZmZXJzCj4gPiA+ID4gCj4gPiA+ ID4gU28gdGhlIGRyaXZlciBpbiBnZW5lcmFsIG5lZWRzIHNvbWUgY2xlYW51cCwgd2hpY2ggY29u dHJpYnV0ZXMgdG8gdGhlCj4gPiA+ID4gcHJvYmxlbS4KPiA+ID4gCj4gPiA+IEFzIGZhciBhcyBJ IHVuZGVyc3RhbmQgdGhlIDRHQiBhcmUgYSBoYXJkd2FyZSBsaW1pdGF0aW9uLgo+ID4gPiAKPiA+ ID4gQWNjb3JkaW5nIHRvIHRoZSByazM1NjggVFJNLCB0aGUgUkdBMl9NTVVfU1JDX0JBU0UgaGFz IDI4IGJpdHMgZm9yIHRoZSB1cHBlcgo+ID4gPiAyOCBiaXRzIG9mIHRoZSBhZGRyZXNzIG9mIHRo ZSBNTVUgVExCLiBUaHVzIHRoZSBNTVUgVExCIG11c3QgYmUgbG9jYXRlZCB3aXRoaW4KPiA+ID4g NEdCIG1lbW9yeS4KPiA+ID4gCj4gPiA+IEFuZCB3aXRoaW4gdGhlIE1NVSBUTEIsIHRoZSBhZGRy ZXNzZXMgYXJlIDMyIGJpdCBhcyB3ZWxsICh1bmxlc3MgSSBhbSBtaXNzaW5nCj4gPiA+IHNvbWV0 aGluZyBpbXBvcnRhbnQpLiBVbmZvcnR1bmF0ZWx5LCBJIGNvdWxkbid0IGZpbmQgYW55IGRvY3Vt ZW50YXRpb24gZm9yIHRoZQo+ID4gPiBUTEIuIFRoZSBkb3duc3RyZWFtIGRyaXZlciB3cml0ZXMg b25seSAzMiBiaXQgYWRkcmVzc2VzIHRvIHRoZSBUTEIgYXMgd2VsbC4KPiA+ID4gVGh1cywgSSBh c3N1bWUgdGhhdCBhbGwgdmlkZW8gYnVmZmVycyBtdXN0IGJlIGxvY2F0ZWQgd2l0aGluIDRHQiBt ZW1vcnksIHRvby4KPiA+ID4gCj4gPiA+IFdoaWxlIEkgYWdyZWUgdGhhdCB0aGUgZHJpdmVyIG5l ZWRzIHNvbWUgY2xlYW51cCBhbmQgbWF5IHVzZSBjb3JyZWN0IHR5cGVzIGZvcgo+ID4gPiBoYW5k bGluZyB0aGUgYml0IHNpemUgbGltaXRhdGlvbiwgSSB0aGluayB0aGlzIGlzbid0IHNvbWUgZHJp dmVyIGxpbWl0YXRpb24uCj4gPiA+IE1heWJlIHRoZSBkcml2ZXIgc2hvdWxkIHNldCB0aGUgZG1h IG1hc2sgdG8gMzIgYml0cyBhbmQgc2hvdWxkIGJlIGV4cGxpY2l0bHkKPiA+ID4gYXdhcmUgb2Yg dGhlIDMyIGJpdCBsaW1pdC4KPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gQnV0IGFzIHdhcyBzYWlk LCB0aGlzIGlzbid0IGEgcHJvYmxlbSB3aXRoIHRoZSBkZXZpY2UgdHJlZSwgc28gaXQgc2hvdWxk Cj4gPiA+ID4gc3RpbGwgbWFrZSBpdCBpbi4gSXQganVzdCBtZWFucyB0aGF0IHRoZSBkcml2ZXIg aXMgYnJva2VuIG9uIDhHQiBSSzM1NnguCj4gPiAKPiA+IE5pY29sYXM6IElzIHRoaXMgeW91ciBB Y2tlZC1CeT8KPiA+IAo+ID4gV2hvIHdvdWxkIHBpY2sgdXAgdGhlIHBhdGNoPyBIZWlrbz8KPiA+ IAo+ID4gTWljaGFlbAo+ID4gCj4gCj4gU3VyZSwKPiAKPiBBY2tlZC1ieTogTmljb2xhcyBGcmF0 dGFyb2xpIDxmcmF0dGFyb2xpLm5pY29sYXNAZ21haWwuY29tPgo+IAo+IFRob3VnaCBJJ20gbm90 IHN1cmUgaG93IG11Y2ggd2VpZ2h0IG15IEFja2VkLWJ5IGNhcnJpZXMgaGVyZS4KPiAKPiBGb3Ig YXBwbHlpbmcgdGhlIHBhdGNoLCB5ZXMgdGhhdCB3b3VsZCBiZSBkb25lIGJ5IEhlaWtvLgoKSG1t LCBub3JtYWxseSB0aGUgYmluZGluZyBnb2VzIHRocm91Z2ggdGhlIHJlbGV2YW50IHN1YnN5c3Rl bSB0cmVlCihtZWRpYSBpbiB0aGlzIGNhc2UpLCBhZnRlciB3aGljaCBJJ2Qgbm9ybWFsbHkgcGlj ayB0aGUgZHRzIHBhdGNoLgpNZWRpYSBpcyBhbHdheXMgcHJldHR5IGhhcmQsIGFzIG9uZSBuZXZl ciByZWFsbHkga25vd3MgaWYgYW5kIHdoZW4gc2FpZApwYXRjaGVzIGdldCBhcHBsaWVkLgoKSSBk b24ndCByZWFsbHkgc2VlIG1lZGlhLXBlb3BsZSBpbiB0aGUgQ2MgbGlzdCBhcyB3ZWxsLCBzbyBk b24ndApyZWFsbHkga25vdyB3aGF0J3MgdGhlIHBsYW4uCgpJIGd1ZXNzIHlvdSBtaWdodCB3YW50 IHRvIHJlc2VuZCB3aXRoIFJldmlld3MgYXBwZW5kZWQgYW5kIGluY2x1ZGUKdGhlIG1lZGlhIHBl b3BsZSArIGxpc3QgZm9yIHRoZSBiaW5kaW5nLiAoT3IgSSdkIG5lZWQgYW4gQWNrIGZyb20Kc29t ZW9uZSBmcm9tIG1lZGlhIGZvciBtZSB0byB0YWtlIHRoZSBiaW5kaW5nKQoKCkhlaWtvCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80A6C46467 for ; Thu, 19 Jan 2023 12:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbjASMP4 convert rfc822-to-8bit (ORCPT ); Thu, 19 Jan 2023 07:15:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbjASMPz (ORCPT ); Thu, 19 Jan 2023 07:15:55 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BE1C6E91 for ; Thu, 19 Jan 2023 04:15:52 -0800 (PST) Received: from wf0783.dip.tu-dresden.de ([141.76.183.15] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pITpV-0002mO-3s; Thu, 19 Jan 2023 13:15:41 +0100 From: Heiko Stuebner To: Michael Tretter , Nicolas Frattaroli , robh+dt@kernel.org, Peter Geis Cc: Ezequiel Garcia , linux-rockchip@lists.infradead.org, Shengyu Qu , devicetree@vger.kernel.org, jacob-chen@iotwrt.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, michael.riesch@wolfvision.net Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x Date: Thu, 19 Jan 2023 13:15:39 +0100 Message-ID: <4455473.LvFx2qVVIh@phil> In-Reply-To: <5241675.okTXgP3Kn8@archbook> References: <20221121151755.2072816-3-m.tretter@pengutronix.de> <20230117124114.GF23495@pengutronix.de> <5241675.okTXgP3Kn8@archbook> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Am Mittwoch, 18. Januar 2023, 01:01:48 CET schrieb Nicolas Frattaroli: > On Dienstag, 17. Januar 2023 13:41:14 CET Michael Tretter wrote: > > On Wed, 23 Nov 2022 10:28:41 +0100, Michael Tretter wrote: > > > On Tue, 22 Nov 2022 20:47:49 +0100, Nicolas Frattaroli wrote: > > > > On Dienstag, 22. November 2022 00:10:25 CET Peter Geis wrote: > > > > > On Mon, Nov 21, 2022 at 12:34 PM Ezequiel Garcia > > > > > wrote: > > > > > > On Mon, Nov 21, 2022 at 2:13 PM Shengyu Qu wrote: > > > > > > > I remember someone said that rga2 has only 32bit address space but not > > > > > > > having a mmu or mmu needs to be configured. Better ask by yourself in > > > > > > > pine64 discord since I'm not sure about that. > > > > > > > 于 2022年11月22日 GMT+08:00 上午12:41:16, Michael Tretter 写到: > > > > > > > >On Tue, 22 Nov 2022 00:01:28 +0800, Shengyu Qu wrote: > > > > > > > >> Someone from pine64 discord found that RGA2 doesn't work properly on over > > > > > > > >> > > > > > > > >> 4GB memory RK3568 devices. Are you sure current driver works now? > > > > > > > > > > > > > > > >I am absolutely sure that the driver works on a 2GB ROCK3A board. > > > > > > > >Unfortunately, I don't have a device with 4GB or more memory and I cannot test > > > > > > > >the driver with such a device. > > > > > > > > > > > > > > > >As the documentation for the RGA2 is the same in the TRM of the rk3288 and > > > > > > > >rk3568, I would guess that the driver doesn't work on a rk3288 with more than > > > > > > > >4GB (if there is such a thing) either and the driver needs to be fixed for > > > > > > > >both SoCs. > > > > > > > > > > > > > > > > > > > > In any case, if there's some kind of issue it must be in the driver, > > > > > > and not in the device tree binding (i.e. this patchset). > > > > > > > > > > An unfortunate number of Rockchip drivers break on rk356x boards with > > > > > more than 4GB of ram. I've found requesting memory allocations with > > > > > the GFP_DMA flag solves the problem, as the kernel only allocates > > > > > 32bit addresses for DMA on rk356x. This is similar to the bug with the > > > > > ITS MSI allocations. > > > > > > > > the problem in this case at least partly seems to be down to the driver > > > > assuming 32 bit addresses, see e.g. [1] (if I understand the code > > > > correctly) and [2]. When I asked in the #armlinux IRC on Libera.chat > > > > about this, Robin Murphy remarked: > > > > > > > > yeesh, the virt_to_phys/dma_sync abuse is even worse > > > > - in that particular instance I'd be inclined to replace > > > > {src,dst}_mmu_pages with proper coherent DMA buffers > > > > > > > > So the driver in general needs some cleanup, which contributes to the > > > > problem. > > > > > > As far as I understand the 4GB are a hardware limitation. > > > > > > According to the rk3568 TRM, the RGA2_MMU_SRC_BASE has 28 bits for the upper > > > 28 bits of the address of the MMU TLB. Thus the MMU TLB must be located within > > > 4GB memory. > > > > > > And within the MMU TLB, the addresses are 32 bit as well (unless I am missing > > > something important). Unfortunately, I couldn't find any documentation for the > > > TLB. The downstream driver writes only 32 bit addresses to the TLB as well. > > > Thus, I assume that all video buffers must be located within 4GB memory, too. > > > > > > While I agree that the driver needs some cleanup and may use correct types for > > > handling the bit size limitation, I think this isn't some driver limitation. > > > Maybe the driver should set the dma mask to 32 bits and should be explicitly > > > aware of the 32 bit limit. > > > > > > > > > > > But as was said, this isn't a problem with the device tree, so it should > > > > still make it in. It just means that the driver is broken on 8GB RK356x. > > > > Nicolas: Is this your Acked-By? > > > > Who would pick up the patch? Heiko? > > > > Michael > > > > Sure, > > Acked-by: Nicolas Frattaroli > > Though I'm not sure how much weight my Acked-by carries here. > > For applying the patch, yes that would be done by Heiko. Hmm, normally the binding goes through the relevant subsystem tree (media in this case), after which I'd normally pick the dts patch. Media is always pretty hard, as one never really knows if and when said patches get applied. I don't really see media-people in the Cc list as well, so don't really know what's the plan. I guess you might want to resend with Reviews appended and include the media people + list for the binding. (Or I'd need an Ack from someone from media for me to take the binding) Heiko