From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp
Date: Mon, 01 May 2006 13:08:03 +0200 [thread overview]
Message-ID: <4455EC13.9040000@bellard.org> (raw)
In-Reply-To: <c1bf1cf0604301955tc9f402r763c3d125479f1b9@mail.gmail.com>
Ed Swierk wrote:
> In several places in qemu's slirp code, signed and unsigned ints are
> used interchangeably when dealing with IP packet lengths and offsets.
> This causes IP packets greater than 32K in length to be scrambled in
> various interesting ways that are extremely difficult to troubleshoot.
>
> Although large IP packets are fairly rare in practice, certain
> UDP-based protocols like NFS use them extensively.
>
> The attached patch wraps IP packet lengths and offsets in macros that
> ensure they are always properly treated as unsigned values.
Why not changing the definition itself to uint16_t and verifying each
occurence of ip_off and ip_len ?
Fabrice.
next prev parent reply other threads:[~2006-05-01 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 2:55 [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp Ed Swierk
2006-05-01 11:08 ` Fabrice Bellard [this message]
2006-05-01 16:19 ` Kenneth Duda
2006-05-01 18:05 ` Fabrice Bellard
2006-05-02 2:11 ` Ed Swierk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4455EC13.9040000@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.