From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D467414006 for ; Sat, 11 Nov 2023 12:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from i5e861929.versanet.de ([94.134.25.41] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1mq2-000124-Ps; Sat, 11 Nov 2023 13:11:46 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Boris Brezillon Cc: kernel test robot , Boris Brezillon , oe-kbuild-all@lists.linux.dev, Steven Price Subject: Re: [mmind-rockchip:dev/panthor 36/41] drivers/gpu/drm/panthor/panthor_drv.c:1326:6: warning: no previous prototype for 'panthor_debugfs_init' Date: Sat, 11 Nov 2023 13:11:45 +0100 Message-ID: <4456426.NG923GbCHz@diego> In-Reply-To: <20231110202058.1c05283a@collabora.com> References: <202311110058.uP4Vh1gN-lkp@intel.com> <3931875.atdPhlSkOF@diego> <20231110202058.1c05283a@collabora.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Am Freitag, 10. November 2023, 20:20:58 CET schrieb Boris Brezillon: > On Fri, 10 Nov 2023 18:21:05 +0100 > Heiko St=FCbner wrote: >=20 > > Hi kernel-test-robot, > >=20 > > please don't build-test my github kernel repository. > >=20 > > I've never enabled anything for this, so I don't even know how it made = it > > in some build-test-list. > >=20 > > This is really only my dumping ground for work-in-progress or test code. > > Case in point, I just wanted to play around with the panthor patches, n= ot > > cause email messages for Boris. >=20 > No worries. Actually, that's good to know I have a few more things to > fix (probably a weird combination of options being enabled/disabled > leading to unused functions/variables). hehe ok, just didn't want to cause you more work. Because I took your patches, moved them onto 6.7-mergewindow and updated the underlying series' with their newest posted versions, I assumed that the breakage could've also be caused by me ;-) . In any case thanks for all that work - seeing glmark2 run that nicely on my first try was a great experience. Heiko > Not trying to say kernel-test-bot should scan your tree, but those > information are useful to me ;-). >=20 > Regards, >=20 > Boris >=20 > >=20 > >=20 > > Thanks a lot > > Heiko > >=20 > > Am Freitag, 10. November 2023, 18:04:14 CET schrieb kernel test robot: > > > Hi Boris, > > >=20 > > > First bad commit (maybe !=3D root cause): > > >=20 > > > tree: https://github.com/mmind/linux-rockchip dev/panthor > > > head: ef8d76d568fba69012333ce6e9d7cce4aebbb2da > > > commit: 86d43fb902f5db2a81e432041864dd7523314c70 [36/41] drm/panthor:= Allow driver compilation > > > config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/2= 0231111/202311110058.uP4Vh1gN-lkp@intel.com/config) > > > compiler: sparc64-linux-gcc (GCC) 13.2.0 > > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/a= rchive/20231111/202311110058.uP4Vh1gN-lkp@intel.com/reproduce) > > >=20 > > > If you fix the issue in a separate patch/commit (i.e. not just a new = version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202311110058.uP4Vh1gN= =2Dlkp@intel.com/ > > >=20 > > > All warnings (new ones prefixed by >>): > > > =20 > > > >> drivers/gpu/drm/panthor/panthor_drv.c:1326:6: warning: no previous= prototype for 'panthor_debugfs_init' [-Wmissing-prototypes] =20 > > > 1326 | void panthor_debugfs_init(struct drm_minor *minor) > > > | ^~~~~~~~~~~~~~~~~~~~ > > > -- > > > drivers/gpu/drm/panthor/panthor_sched.c: In function 'cs_slot_proc= ess_fatal_event_locked': =20 > > > >> drivers/gpu/drm/panthor/panthor_sched.c:1233:37: warning: variable= 'csg_iface' set but not used [-Wunused-but-set-variable] =20 > > > 1233 | struct panthor_fw_cs_iface *csg_iface; > > > | ^~~~~~~~~ > > > drivers/gpu/drm/panthor/panthor_sched.c: In function 'cs_slot_proc= ess_tiler_oom_event_locked': =20 > > > >> drivers/gpu/drm/panthor/panthor_sched.c:1321:13: warning: variable= 'info' set but not used [-Wunused-but-set-variable] =20 > > > 1321 | u64 info, heap_address, new_chunk_va; > > > | ^~~~ =20 > > > >> drivers/gpu/drm/panthor/panthor_sched.c:1319:13: warning: variable= 'fault' set but not used [-Wunused-but-set-variable] =20 > > > 1319 | u32 fault, vt_start, vt_end, frag_end; > > > | ^~~~~ =20 > > > >> drivers/gpu/drm/panthor/panthor_sched.c:1318:31: warning: variable= 'queue' set but not used [-Wunused-but-set-variable] =20 > > > 1318 | struct panthor_queue *queue; > > > | ^~~~~ > > > drivers/gpu/drm/panthor/panthor_sched.c: In function 'tick_ctx_app= ly': > > > drivers/gpu/drm/panthor/panthor_sched.c:1983:54: warning: variable= 'csg_iface' set but not used [-Wunused-but-set-variable] > > > 1983 | struct panthor_fw_csg_iface *csg_i= face; > > > | ^~~~~= ~~~~ > > > drivers/gpu/drm/panthor/panthor_sched.c: In function 'panthor_sche= d_suspend': =20 > > > >> drivers/gpu/drm/panthor/panthor_sched.c:2481:13: warning: variable= 'ret' set but not used [-Wunused-but-set-variable] =20 > > > 2481 | int ret; > > > | ^~~ > > > drivers/gpu/drm/panthor/panthor_sched.c: In function 'group_create= _queue': > > > drivers/gpu/drm/panthor/panthor_sched.c:2927:53: error: 'DRM_SCHED= _POLICY_SINGLE_ENTITY' undeclared (first use in this function) > > > 2927 | NULL, "panthor-queue", DRM_SC= HED_POLICY_SINGLE_ENTITY, > > > | ^~~~~~= ~~~~~~~~~~~~~~~~~~~~~~~~ > > > drivers/gpu/drm/panthor/panthor_sched.c:2927:53: note: each undecl= ared identifier is reported only once for each function it appears in > > > drivers/gpu/drm/panthor/panthor_sched.c:2926:49: warning: passing = argument 7 of 'drm_sched_init' makes integer from pointer without a cast [-= Wint-conversion] > > > 2926 | group->ptdev->reset.wq, > > > | ~~~~~~~~~~~~~~~~~~~^~~ > > > | | > > > | struct wor= kqueue_struct * > > > In file included from drivers/gpu/drm/panthor/panthor_sched.c:9: > > > include/drm/gpu_scheduler.h:533:25: note: expected 'long int' but = argument is of type 'struct workqueue_struct *' > > > 533 | long timeout, struct workqueue_struct *= timeout_wq, > > > | ~~~~~^~~~~~~ > > > drivers/gpu/drm/panthor/panthor_sched.c:2927:36: error: passing ar= gument 9 of 'drm_sched_init' from incompatible pointer type [-Werror=3Dinco= mpatible-pointer-types] > > > 2927 | NULL, "panthor-queue", DRM_SC= HED_POLICY_SINGLE_ENTITY, > > > | ^~~~~~~~~~~~~~~ > > > | | > > > | char * > > > include/drm/gpu_scheduler.h:534:30: note: expected 'atomic_t *' bu= t argument is of type 'char *' > > > 534 | atomic_t *score, const char *name, stru= ct device *dev); > > > | ~~~~~~~~~~^~~~~ > > > cc1: some warnings being treated as errors > > > -- =20 > > > >> drivers/gpu/drm/panthor/panthor_devfreq.c:43: warning: Function pa= rameter or member 'lock' not described in 'panthor_devfreq' =20 > > > -- =20 > > > >> drivers/gpu/drm/panthor/panthor_gem.c:167: warning: Function param= eter or member 'ddev' not described in 'panthor_gem_create_object' > > > >> drivers/gpu/drm/panthor/panthor_gem.c:167: warning: Excess functio= n parameter 'dev' description in 'panthor_gem_create_object' =20 > > > -- =20 > > > >> drivers/gpu/drm/panthor/panthor_heap.c:339: warning: Function para= meter or member 'new_chunk_gpu_va' not described in 'panthor_heap_grow' =20 > > > -- =20 > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:52: warning: Function parame= ter or member 'product_major' not described in 'panthor_model' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:64: warning: Function parame= ter or member '_name' not described in 'GPU_MODEL' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:64: warning: Function parame= ter or member '_arch_major' not described in 'GPU_MODEL' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:64: warning: Function parame= ter or member '_product_major' not described in 'GPU_MODEL' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:168: warning: Function param= eter or member 'ptdev' not described in 'panthor_gpu_unplug' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:234: warning: Function param= eter or member 'timeout_us' not described in 'panthor_gpu_block_power_off' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:234: warning: Excess functio= n parameter 'timeout_ms' description in 'panthor_gpu_block_power_off' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:294: warning: Function param= eter or member 'rdy_reg' not described in 'panthor_gpu_block_power_on' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:294: warning: Function param= eter or member 'timeout_us' not described in 'panthor_gpu_block_power_on' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:294: warning: Excess functio= n parameter 'timeout_ms' description in 'panthor_gpu_block_power_on' > > > >> drivers/gpu/drm/panthor/panthor_gpu.c:472: warning: Function param= eter or member 'ptdev' not described in 'panthor_gpu_resume' =20 > > > -- =20 > > > >> drivers/gpu/drm/panthor/panthor_drv.c:84: warning: Function parame= ter or member 'obj_size' not described in 'panthor_get_uobj_array' > > > >> drivers/gpu/drm/panthor/panthor_drv.c:84: warning: Excess function= parameter 'obj_kernel' description in 'panthor_get_uobj_array' > > > >> drivers/gpu/drm/panthor/panthor_drv.c:268: warning: Function param= eter or member 'syncops' not described in 'panthor_job_ctx' > > > >> drivers/gpu/drm/panthor/panthor_drv.c:732: warning: Function param= eter or member 'job_put' not described in 'panthor_submit_ctx_cleanup' > > > >> drivers/gpu/drm/panthor/panthor_drv.c:1406: warning: Cannot unders= tand * @cleanup_wq: Workqueue used to cleanup stuff. =20 > > > on line 1406 - I thought it was a doc line > > > -- =20 > > > >> drivers/gpu/drm/panthor/panthor_fw.c:293: warning: expecting proto= type for panthor_fw_get_glb_iface(). Prototype was for panthor_fw_get_csg_i= face() instead > > > >> drivers/gpu/drm/panthor/panthor_fw.c:310: warning: expecting proto= type for panthor_fw_get_glb_iface(). Prototype was for panthor_fw_get_cs_if= ace() instead > > > >> drivers/gpu/drm/panthor/panthor_fw.c:438: warning: Function parame= ter or member 'input_fw_va' not described in 'panthor_fw_alloc_queue_iface_= mem' > > > >> drivers/gpu/drm/panthor/panthor_fw.c:438: warning: Function parame= ter or member 'output_fw_va' not described in 'panthor_fw_alloc_queue_iface= _mem' > > > >> drivers/gpu/drm/panthor/panthor_fw.c:1190: warning: Function param= eter or member 'csg_slot' not described in 'panthor_fw_csg_wait_acks' > > > >> drivers/gpu/drm/panthor/panthor_fw.c:1190: warning: expecting prot= otype for panthor_fw_glb_wait_acks(). Prototype was for panthor_fw_csg_wait= _acks() instead =20 > > >=20 > > >=20 > > > vim +/panthor_debugfs_init +1326 drivers/gpu/drm/panthor/panthor_drv.c > > >=20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1324 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1325 #ifdef CONFIG_DEBUG_= =46S > > > 560b6916e77920 Boris Brezillon 2023-08-09 @1326 void panthor_debugfs= _init(struct drm_minor *minor) > > > 560b6916e77920 Boris Brezillon 2023-08-09 1327 { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1328 panthor_mmu_debugfs= _init(minor); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1329 } > > > 560b6916e77920 Boris Brezillon 2023-08-09 1330 #endif > > > 560b6916e77920 Boris Brezillon 2023-08-09 1331 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1332 /* > > > 560b6916e77920 Boris Brezillon 2023-08-09 1333 * PanCSF driver ver= sion: > > > 560b6916e77920 Boris Brezillon 2023-08-09 1334 * - 1.0 - initial i= nterface > > > 560b6916e77920 Boris Brezillon 2023-08-09 1335 */ > > > 560b6916e77920 Boris Brezillon 2023-08-09 1336 static const struct = drm_driver panthor_drm_driver =3D { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1337 .driver_features = =3D DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ | > > > 560b6916e77920 Boris Brezillon 2023-08-09 1338 DRIVER_SYNCOBJ= _TIMELINE | DRIVER_GEM_GPUVA, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1339 .open =3D panthor_o= pen, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1340 .postclose =3D pant= hor_postclose, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1341 .ioctls =3D panthor= _drm_driver_ioctls, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1342 .num_ioctls =3D ARR= AY_SIZE(panthor_drm_driver_ioctls), > > > 560b6916e77920 Boris Brezillon 2023-08-09 1343 .fops =3D &panthor_= drm_driver_fops, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1344 .name =3D "panthor", > > > 560b6916e77920 Boris Brezillon 2023-08-09 1345 .desc =3D "Panthor = DRM driver", > > > 560b6916e77920 Boris Brezillon 2023-08-09 1346 .date =3D "20230801= ", > > > 560b6916e77920 Boris Brezillon 2023-08-09 1347 .major =3D 1, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1348 .minor =3D 0, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1349 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1350 .gem_create_object = =3D panthor_gem_create_object, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1351 .gem_prime_import_s= g_table =3D drm_gem_shmem_prime_import_sg_table, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1352 #ifdef CONFIG_DEBUG_= =46S > > > 560b6916e77920 Boris Brezillon 2023-08-09 1353 .debugfs_init =3D p= anthor_debugfs_init, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1354 #endif > > > 560b6916e77920 Boris Brezillon 2023-08-09 1355 }; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1356 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1357 static int panthor_p= robe(struct platform_device *pdev) > > > 560b6916e77920 Boris Brezillon 2023-08-09 1358 { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1359 struct panthor_devi= ce *ptdev; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1360 int ret; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1361 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1362 ptdev =3D devm_drm_= dev_alloc(&pdev->dev, &panthor_drm_driver, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1363 struct pantho= r_device, base); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1364 if (!ptdev) > > > 560b6916e77920 Boris Brezillon 2023-08-09 1365 return -ENOMEM; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1366 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1367 platform_set_drvdat= a(pdev, ptdev); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1368 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1369 ret =3D panthor_dev= ice_init(ptdev); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1370 if (ret) > > > 560b6916e77920 Boris Brezillon 2023-08-09 1371 return ret; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1372 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1373 return drm_dev_regi= ster(&ptdev->base, 0); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1374 } > > > 560b6916e77920 Boris Brezillon 2023-08-09 1375 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1376 static void panthor_= remove(struct platform_device *pdev) > > > 560b6916e77920 Boris Brezillon 2023-08-09 1377 { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1378 struct panthor_devi= ce *ptdev =3D platform_get_drvdata(pdev); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1379 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1380 panthor_device_unpl= ug(ptdev); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1381 } > > > 560b6916e77920 Boris Brezillon 2023-08-09 1382 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1383 static const struct = of_device_id dt_match[] =3D { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1384 { .compatible =3D "= rockchip,rk3588-mali" }, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1385 { .compatible =3D "= arm,mali-valhall-csf" }, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1386 {} > > > 560b6916e77920 Boris Brezillon 2023-08-09 1387 }; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1388 MODULE_DEVICE_TABLE(= of, dt_match); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1389 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1390 static DEFINE_RUNTIM= E_DEV_PM_OPS(panthor_pm_ops, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1391 panthor_device_= suspend, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1392 panthor_device_= resume, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1393 NULL); > > > 560b6916e77920 Boris Brezillon 2023-08-09 1394 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1395 static struct platfo= rm_driver panthor_driver =3D { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1396 .probe =3D panthor_= probe, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1397 .remove_new =3D pan= thor_remove, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1398 .driver =3D { > > > 560b6916e77920 Boris Brezillon 2023-08-09 1399 .name =3D "panthor= ", > > > 560b6916e77920 Boris Brezillon 2023-08-09 1400 .pm =3D &panthor_p= m_ops, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1401 .of_match_table = =3D dt_match, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1402 }, > > > 560b6916e77920 Boris Brezillon 2023-08-09 1403 }; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1404 =20 > > > 560b6916e77920 Boris Brezillon 2023-08-09 1405 /** > > > 560b6916e77920 Boris Brezillon 2023-08-09 @1406 * @cleanup_wq: Work= queue used to cleanup stuff. > > > 560b6916e77920 Boris Brezillon 2023-08-09 1407 * > > > 560b6916e77920 Boris Brezillon 2023-08-09 1408 * We create a dedic= ated workqueue so we can drain on unplug and > > > 560b6916e77920 Boris Brezillon 2023-08-09 1409 * make sure all res= ources are freed before the module is unloaded. > > > 560b6916e77920 Boris Brezillon 2023-08-09 1410 */ > > > 560b6916e77920 Boris Brezillon 2023-08-09 1411 struct workqueue_str= uct *panthor_cleanup_wq; > > > 560b6916e77920 Boris Brezillon 2023-08-09 1412 =20 > > >=20 > > > :::::: The code at line 1326 was first introduced by commit > > > :::::: 560b6916e779201356a8db10cec8dc5183d9fe5f drm/panthor: Add the = driver frontend block > > >=20 > > > :::::: TO: Boris Brezillon > > > :::::: CC: Heiko Stuebner > > >=20 > > > =20 > >=20 > >=20 > >=20 > >=20 >=20 >=20