All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] built-in "git grep" (git grip).
Date: Tue, 02 May 2006 10:33:43 +0200	[thread overview]
Message-ID: <44571967.7080807@op5.se> (raw)
In-Reply-To: <e34cb4$is1$1@sea.gmane.org>

Jakub Narebski wrote:
> Junio C Hamano wrote:
> 
> Jakub Narebski <jnareb@gmail.com> writes:
> 
> 
>>Wouldn't "git ggrep" (from git-aware grep) or "git bgrep" (from built-in
>>grep), similar to the egrep and fgrep from the grep package?
> 
> 
> Yes, I understand, but I just don't like using 'grip'. And it would be nice
> to have some convention for further not-ready-yet built-in replacements for
> script versions of commands, for example adding letter 'b' as 'built-in' at
> the beginning of command name: 'bgrep', 'bdiff'. Or use postfix 'n' or
> '-ng' to denote transitionary not-ready-yet new version of command:
> 'grepn', 'diffn' or 'grep-ng', 'diff-ng'.
> 

Forcing the user to remember what's implemented as built-ins is not a 
good idea. It was for that exact reason the "git-<command>-script" were 
all renamed "git-<command>" once upon a time.

"git grip" work just fine for me, since it's only intended for testing 
and performance improvements so far. I also think it's clearer for 
end-users looking for a grep command if they're not faced with 
fgrep/egrep/ggrep/bgrep alongside plain "grep".

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  reply	other threads:[~2006-05-02  8:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-01  6:32 [PATCH] built-in "git grep" (git grip) Junio C Hamano
2006-05-01  6:56 ` Jakub Narebski
2006-05-01  6:59   ` Junio C Hamano
2006-05-01  7:12     ` Jakub Narebski
2006-05-02  8:33       ` Andreas Ericsson [this message]
2006-05-02  8:44         ` Jakub Narebski
2006-05-02  9:01         ` Junio C Hamano
2006-05-02  9:25           ` Jakub Narebski
2006-05-02  9:39             ` Andreas Ericsson
2006-05-02 19:07             ` Junio C Hamano
2006-05-02 21:23               ` Linus Torvalds
2006-05-02 21:54                 ` Junio C Hamano
2006-05-02 23:07                   ` Linus Torvalds
2006-05-03  0:01                   ` Junio C Hamano
2006-05-01  7:30 ` [PATCH] built-in "git grep" (git grip) - quickfix Junio C Hamano
2006-05-01 14:04 ` [PATCH] built-in "git grep" (git grip) Sam Ravnborg
2006-05-01 14:07   ` Sam Ravnborg
2006-05-01 14:53     ` Sam Ravnborg
2006-05-01 15:48       ` Linus Torvalds
2006-05-01 19:30         ` [PATCH] builtin-grep: wildcard pathspec fixes Junio C Hamano
2006-05-01 23:24           ` [PATCH] builtin-grep: do not use setup_revisions() Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44571967.7080807@op5.se \
    --to=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.