All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Kalus <tkalus@us.xyratex.com>
To: dm-devel@redhat.com
Subject: [PATCH] pp_aula/spc.h
Date: Tue, 02 May 2006 15:32:02 -0700	[thread overview]
Message-ID: <4457DDE2.6050607@us.xyratex.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

path_priority/pp_aula/spc.h

Isn't the inquiry_data.product_identifier 16 bytes long? or do I need a 
later draft of SPC3... 21d - Feb 2005
Bug doesn't effect existing code, but it's still a bug.
Rest looks ok, so far as I can tell.

See attached patch.



[-- Attachment #2: spc3.h.patch --]
[-- Type: text/plain, Size: 774 bytes --]

diff --git a/path_priority/pp_alua/spc3.h b/path_priority/pp_alua/spc3.h
index 11f5dbd..bddbbdd 100644
--- a/path_priority/pp_alua/spc3.h
+++ b/path_priority/pp_alua/spc3.h
@@ -148,10 +148,10 @@ struct inquiry_data {
 					/* ......x. = command queue support  */
 					/* .......x = vs2                    */
 	unsigned char	vendor_identification[8];
-	unsigned char	product_identification[8];
+	unsigned char	product_identification[16];
 	unsigned char	product_revision[4];
 	unsigned char	vendor_specific[20];
-	unsigned char	b48;		/* xxxx.... = reserved               */
+	unsigned char	b56;		/* xxxx.... = reserved               */
 					/* ....xx.. = clocking               */
 					/* ......x. = qas                    */
 					/* .......x = ius                    */

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-05-02 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02 22:32 Tom Kalus [this message]
2006-05-04 14:56 ` [PATCH] pp_aula/spc.h Christophe Varoqui
2006-05-04 15:20   ` Stefan Bader
2006-05-04 21:38 ` Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4457DDE2.6050607@us.xyratex.com \
    --to=tkalus@us.xyratex.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.