From: Dirk Behme <dirk.behme@googlemail.com>
To: linux-omap-open-source@linux.omap.com
Subject: Re: Undefined usb_disconnect
Date: Fri, 05 May 2006 06:50:11 +0200 [thread overview]
Message-ID: <445AD983.7060908@gmail.com> (raw)
In-Reply-To: <200605040932.46678.david-b@pacbell.net>
David Brownell wrote:
> On Thursday 04 May 2006 9:08 am, Dirk Behme wrote:
>>David Brownell wrote:
>>>On Wednesday 03 May 2006 11:41 am, Dirk Behme wrote:
>>>I see a curious and pointless routine, ohci_omap_host_enable(), which
>>>isn't called from anywhere I can see, which wants usb_disconnect().
>>>
>>>Try deleting that routine.
>>
>>tahvo-usb.c uses ohci_omap_host_enable():
>
> And so it does. That would be a bug in how the Tahvo transceiver is
> trying to activate the USB host. It should be able to just use
> the normal power management suspend and resume calls... certainly
> there's no benefit to creating transceiver-specific backdoors into
> usbcore for runtime PM.
Anybody like to fix and test tahvo-usb.c regarding this?
Then we could remove ohci_omap_host_enable() from
drivers/usb/host/ohci-omap.c .
Cheers
Dirk
next prev parent reply other threads:[~2006-05-05 4:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 15:44 [PATCH] ARM: OMAP: Fix tlv320aic23.c Dirk Behme
2006-05-03 12:56 ` Tony Lindgren
2006-05-03 18:41 ` Dirk Behme
2006-05-04 14:51 ` David Brownell
2006-05-04 16:08 ` Undefined usb_disconnect, was " Dirk Behme
2006-05-04 16:32 ` David Brownell
2006-05-05 4:50 ` Dirk Behme [this message]
2006-05-05 8:08 ` Undefined usb_disconnect Hiroshi DOYU
2006-05-27 6:38 ` Dirk Behme
2006-05-27 15:43 ` David Brownell
2006-05-28 13:21 ` Dirk Behme
2006-05-28 16:17 ` David Brownell
2006-07-04 8:20 ` tony
2006-05-03 19:42 ` [PATCH] ARM: OMAP: Fix tlv320aic23.c lamikr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445AD983.7060908@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.