From: Michael Reed <mdr@sgi.com>
To: linux-scsi <linux-scsi@vger.kernel.org>
Cc: James.Smart@Emulex.Com
Subject: [PATCH] scsi_queue_work() documented return value is incorrect
Date: Fri, 05 May 2006 09:18:43 -0500 [thread overview]
Message-ID: <445B5EC3.5060808@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
If you examine the queue_work() routine you'll see that it returns
1 on success, 0 on not queuing the work.
This patch corrects the source code documentation for the function.
Mike
[-- Attachment #2: scsi_queue_work.patch --]
[-- Type: text/x-patch, Size: 523 bytes --]
Fix scsi_queue_work function documentation.
Signed-off-by: Michael Reed <mdr@sgi.com>
--- rc3u/drivers/scsi/hosts.c 2006-04-27 12:32:05.000000000 -0500
+++ rc3/drivers/scsi/hosts.c 2006-05-05 09:12:53.347943283 -0500
@@ -487,7 +487,9 @@
* @work: Work to queue for execution.
*
* Return value:
- * 0 on success / != 0 for error
+ * 1 - work queued for execution
+ * 0 - work is already queued
+ * -EINVAL - work queue doesn't exist
**/
int scsi_queue_work(struct Scsi_Host *shost, struct work_struct *work)
{
reply other threads:[~2006-05-05 14:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445B5EC3.5060808@sgi.com \
--to=mdr@sgi.com \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.