All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Riffard <laurent.riffard@free.fr>
To: Joe Feise <jfeise@feise.com>
Cc: "Vladimir V. Saveliev" <vs@namesys.com>, reiserfs-list@namesys.com
Subject: Re: BUG on reiser4_delete_inode
Date: Sat, 06 May 2006 07:51:50 +0200	[thread overview]
Message-ID: <445C3976.6090007@free.fr> (raw)
In-Reply-To: <20060505183245.5243.qmail@pv105234.reshsg.uci.edu>


[-- Attachment #1.1: Type: text/plain, Size: 280 bytes --]

Le 05.05.2006 20:32, Joe Feise a écrit :
> The patch doesn't seem to have made it to the list. I have run into the
> same problem...
> -Joe

Vladimir's mail never reached the list despite the fact it was CC'ed to.

Here is the patch that Vladimir sent. 
~~
laurent



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: reiser4-radix-tree-direct-data-fix.patch --]
[-- Type: text/x-patch; name="reiser4-radix-tree-direct-data-fix.patch", Size: 1272 bytes --]

Date: Fri, 05 May 2006 17:38:21 +0400
Subject: No Subject
Message-Id: <1146836301.6254.25.camel@tribesman.namesys.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
From: 

From: Vladimir Saveliev <vs@namesys.com>

Reiser4 used to check radix tree emptiness by comparing tree height against 0.
With radix-tree-direct-data.patch not empty tree can have zero height.
This patch makes reiser4 to check tree emptiness using tree root.

Signed-off-by: Vladimir V. Saveliev <vs@namesys.com>


 fs/reiser4/jnode.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/reiser4/jnode.c~reiser4-radix-tree-direct-data-fix fs/reiser4/jnode.c
--- linux-2.6.17-rc2-mm1/fs/reiser4/jnode.c~reiser4-radix-tree-direct-data-fix	2006-05-05 13:53:47.000000000 +0400
+++ linux-2.6.17-rc2-mm1-vs/fs/reiser4/jnode.c	2006-05-05 13:54:49.000000000 +0400
@@ -432,7 +432,7 @@ static void inode_attach_jnode(jnode * n
 	inode = node->key.j.mapping->host;
 	info = reiser4_inode_data(inode);
 	rtree = jnode_tree_by_reiser4_inode(info);
-	if (rtree->height == 0) {
+	if (rtree->height == 0 && rtree->rnode == NULL) {
 		/* prevent inode from being pruned when it has jnodes attached
 		   to it */
 		write_lock_irq(&inode->i_data.tree_lock);

_

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

  reply	other threads:[~2006-05-06  5:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-04 20:21 BUG on reiser4_delete_inode Laurent Riffard
     [not found] ` <1146836304.6254.26.camel@tribesman.namesys.com>
2006-05-05 16:55   ` Laurent Riffard
2006-05-05 18:32     ` Joe Feise
2006-05-06  5:51       ` Laurent Riffard [this message]
2006-05-06  6:27         ` Joe Feise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445C3976.6090007@free.fr \
    --to=laurent.riffard@free.fr \
    --cc=jfeise@feise.com \
    --cc=reiserfs-list@namesys.com \
    --cc=vs@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.