From: Jes Sorensen <jes@sgi.com>
To: Grant Coady <gcoady.lk@gmail.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
Brent Casavant <bcasavan@sgi.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
akpm@osdl.org, jeremy@sgi.com
Subject: Re: [PATCH] Move various PCI IDs to header file
Date: Mon, 08 May 2006 09:55:20 +0200 [thread overview]
Message-ID: <445EF968.3080903@sgi.com> (raw)
In-Reply-To: <0jkn52lnu505eb26plf5o7buertimg2e6v@4ax.com>
Grant Coady wrote:
> When I worked on pci_ids.h cleanup last year I didn't get a clear
> idea of whether moving all #defines to the one header file was
> desired. Last I looked there were heaps of them scattered all
> over. Is there a preferred model for placing these #defines?
>
> Grant.
According to the document Randy referenced, the preferred place for
*new* defines is to stick them in the local files where they are used.
I don't think there is any preference for moving the out of pci_ids.h
as it would just cause patch noise for the sake of making noise.
So much for being able to go through the pci_ids.h file to get an idea
about whether or not a device may have a chance of being supported :(
Jes
next prev parent reply other threads:[~2006-05-08 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 23:09 [PATCH] Move various PCI IDs to header file Brent Casavant
2006-05-05 0:37 ` Randy.Dunlap
2006-05-05 5:45 ` Jes Sorensen
2006-05-05 13:34 ` Greg KH
2006-05-13 4:29 ` Jeff Garzik
2006-05-05 16:27 ` Randy.Dunlap
2006-05-05 22:37 ` Grant Coady
2006-05-05 22:37 ` Grant Coady
2006-05-08 7:55 ` Jes Sorensen [this message]
2006-05-08 8:31 ` Arjan van de Ven
2006-05-08 8:35 ` Jes Sorensen
2006-05-05 14:09 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445EF968.3080903@sgi.com \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=bcasavan@sgi.com \
--cc=gcoady.lk@gmail.com \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.