All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: qemu disk on vfat
Date: Mon, 08 May 2006 20:36:15 -0500	[thread overview]
Message-ID: <445FF20F.5070309@codemonkey.ws> (raw)
In-Reply-To: <20060508235024.GA18407@jbrown.mylinuxbox.org>

Jim C. Brown wrote:
> Aactually, the bug is in vfat not in qemu-img.
>   

Not really.  POSIX doesn't mandate that ftruncate() increase a file 
size.  This is a Linux-ism and is only valid for filesystems that 
support holes (which vfat doesn't).

Regards,

Anthony Liguori

> qemu-img correctly uses ftruncate() which is suppose to make the file sparse
> if the underlying filesystem supports it, but it should fall back to adding zeros
> to the end of the file. On vfat you aren't able to seek past the end of a file
> period, so this doesn't work.
>
> Probably qemu-img should just bail out in this case (as the other disk formats
> should work fine and you can always use dd). The 2nd patch I released does
> this - the error message just needs to be made more accurate.
>
>   

  reply	other threads:[~2006-05-09  1:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-08 10:04 [Qemu-devel] qemu disk on vfat Yann Le Doaré
2006-05-07  8:44 ` André Braga
2006-05-08 10:41   ` Yann Le Doaré
2006-05-07 15:50     ` [Qemu-devel] " Alex
2006-05-07 11:00 ` [Qemu-devel] " NyOS
2006-05-07 13:47   ` Jernej Simončič
2006-05-08 19:44   ` Yann Le Doaré
2006-05-08 14:57     ` Jan Marten Simons
2006-05-09 21:05       ` Yann Le Doaré
2006-05-07 11:21 ` Johannes Schindelin
2006-05-08 21:12 ` [Qemu-devel] " Anthony Liguori
2006-05-09 23:41   ` Yann Le Doaré
2006-05-08 22:05     ` Michael McConnell
2006-05-08 22:48       ` Jim C. Brown
2006-05-08 23:10         ` Jim C. Brown
2006-05-08 23:50           ` Jim C. Brown
2006-05-09  1:36             ` Anthony Liguori [this message]
2006-05-09  2:11               ` Paul Brook
2006-05-16 17:21             ` Jim C. Brown
2006-05-08 22:23     ` Ian C. Blenke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445FF20F.5070309@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.