From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: bhelgaas@google.com, rdunlap@infradead.org, geert@linux-m68k.org,
hch@lst.de
Subject: Re: powerpc/44x: Force PCI on for CURRITUCK
Date: Fri, 22 Feb 2019 20:47:47 +1100 (AEDT) [thread overview]
Message-ID: <445RN34yW3z9sDr@ozlabs.org> (raw)
In-Reply-To: <20190207024935.30456-1-mpe@ellerman.id.au>
On Thu, 2019-02-07 at 02:49:35 UTC, Michael Ellerman wrote:
> The recent rework of PCI kconfig symbols exposed an existing bug in
> the CURRITUCK kconfig logic.
>
> It selects PPC4xx_PCI_EXPRESS which depends on PCI, but PCI is user
> selectable and might be disabled, leading to a warning:
>
> WARNING: unmet direct dependencies detected for PPC4xx_PCI_EXPRESS
> Depends on [n]: PCI [=n] && 4xx [=y]
> Selected by [y]:
> - CURRITUCK [=y] && PPC_47x [=y]
>
> Prior to commit eb01d42a7778 ("PCI: consolidate PCI config entry in
> drivers/pci") PCI was enabled by default for currituck_defconfig so we
> didn't see the warning. The bad logic was still there, it just
> required someone disabling PCI in their .config to hit it.
>
> Fix it by forcing PCI on for CURRITUCK, which seems was always the
> expectation anyway.
>
> Fixes: eb01d42a7778 ("PCI: consolidate PCI config entry in drivers/pci")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/aa7150ba378650d0e9d84b8e4d805946
cheers
prev parent reply other threads:[~2019-02-22 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 2:49 [PATCH] powerpc/44x: Force PCI on for CURRITUCK Michael Ellerman
2019-02-07 5:37 ` Christoph Hellwig
2019-02-07 8:18 ` Geert Uytterhoeven
2019-02-08 11:46 ` Michael Ellerman
2019-02-22 9:47 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445RN34yW3z9sDr@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.