From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] paging_enabled and non-HVM guests Date: Tue, 09 May 2006 15:14:42 -0500 Message-ID: <4460F832.4060808@us.ibm.com> References: <87wtcv5t9e.wl%simon.kagstrom@bth.se> <1147204426.19485.67.camel@basalt.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1147204426.19485.67.camel@basalt.austin.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Hollis Blanchard Cc: Simon Kagstrom , xen-devel list , Ryan Harper List-Id: xen-devel@lists.xenproject.org Hollis Blanchard wrote: > On Tue, 2006-05-09 at 13:31 +0200, Simon Kagstrom wrote: > >> I had a problem with the GDB-server crashing on connections in >> xen_ptrace.c:map_domain_va(). paging_enabled() should only be checked >> for HVM guests, and the patch adds a check for that. >> >> Signed-off-by: Simon Kagstrom >> >> diff -r 4501d60d6add tools/libxc/xc_ptrace.c >> --- a/tools/libxc/xc_ptrace.c Tue May 9 09:57:05 2006 >> +++ b/tools/libxc/xc_ptrace.c Tue May 9 13:26:14 2006 >> @@ -374,7 +374,7 @@ >> if (fetch_regs(xc_handle, cpu, NULL)) >> return NULL; >> >> - if (!paging_enabled(&ctxt[cpu])) { >> + if ( (ctxt[cpu].flags & VGCF_HVM_GUEST) && !paging_enabled(&ctxt[cpu])) { >> static void * v; >> unsigned long page; >> > > I looked at this a couple weeks ago, and I think the real problem is > that the CR registers are never updated in Xen's vcpu structure, and so > xc_vcpu_getcontext() doesn't get them either. So Xen should be fixed; we > shouldn't add workarounds to userland. > I think that the CR registers are never changed during the life of a PV domain. I think all that's needed is for some sane values to be set during domain creation and things start working. I believe Ryan had a patch that did this? Regards, Anthony Liguori