Re: [PATCH -mm] sata_vsc gcc 4.1 warning fix

[Tejun Heo <htejun@gmail.com>]

Daniel Walker wrote:
> On Wed, 2006-05-10 at 13:20 +0900, Tejun Heo wrote:
>> Daniel Walker wrote:
>>> Fixes the following warning,
>>>
>>> drivers/scsi/sata_vsc.c:152: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:153: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:154: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:155: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:156: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:158: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:159: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:160: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:161: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:162: warning: passing argument 2 of 'writew' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:166: warning: passing argument 2 of 'writeb' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c: In function 'vsc_sata_tf_read':
>>> drivers/scsi/sata_vsc.c:178: warning: passing argument 1 of 'readw' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:179: warning: passing argument 1 of 'readw' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:180: warning: passing argument 1 of 'readw' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:181: warning: passing argument 1 of 'readw' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:182: warning: passing argument 1 of 'readw' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:183: warning: passing argument 1 of 'readw' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c: In function 'vsc_sata_setup_port':
>>> drivers/scsi/sata_vsc.c:320: warning: passing argument 2 of 'writel' makes pointer from integer without a cast
>>> drivers/scsi/sata_vsc.c:321: warning: passing argument 2 of 'writel' makes pointer from integer without a cast
>>>
>>> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>>>
>> Hello, Daniel.
>>
>> This fix comes up every so often and I have submitted almost identical 
>> patch several months ago.  Unfortunately, it's not the proper fix and 
>> won't be accepted.  All those read/writeX()'s and in/outX()'s are 
>> scheduled (for a looooong time) to be converted to new unified 
>> ioread/writeX()'s.  Things are in progress (well, or halt) in the #iomap 
>> branch of libata-dev devel tree.  libata needs some updates in host 
>> initialization part for this conversion to complete.
> 
> I guess subconsciously I knew as much, but I've seen warning like these
> during compiles for a very very very long time .. Considering how
> trivial it is to silence them I don't see why it shouldn't be accepted .
> The "right" fix should have arrived by now ..
> 

Well, it was Jeff's (the maintainer) call.  The warning messages bug me
too but I sort of understand Jeff's decision as the bugging actually
reminds me of the problem every time I build libata.  Well, let's hope
iomap gets completed in not too distant future

Thanks.

-- 
tejun