From: "bibo,mao" <bibo.mao@intel.com>
To: akpm@osdl.org
Cc: Andi Kleen <ak@suse.de>, Jan Beulich <jbeulich@novell.com>,
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH]x86_64 debug_stack nested patch
Date: Wed, 10 May 2006 14:45:33 +0800 [thread overview]
Message-ID: <44618C0D.6020604@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
hi,
In x86_64 platform, INT1 and INT3 trap stack is IST stack called
DEBUG_STACK, when INT1/INT3 trap happens, system will switch to
DEBUG_STACK by hardware. Current DEBUG_STACK size is 4K, when int1/int3
trap happens, kernel will minus current DEBUG_STACK IST value by 4k. But
if int3/int1 trap is nested, it will destroy other vector's IST stack.
This patch modifies this, it sets DEBUG_STACK size as 8K and allows two
level of nested int1/int3 trap.
Kprobe DEBUG_STACK may be nested, because kprobe hanlder may be probed
by other kprobes. This patch is against 2.6.17-rc3.
Signed-Off-By: bibo, mao <bibo.mao@intel.com>
Thanks
bibo,mao
[-- Attachment #2: DEBUG_STACK_NEST.patch --]
[-- Type: text/x-patch, Size: 2213 bytes --]
diff -Nruap 2.6.17-rc3.org/arch/x86_64/kernel/traps.c 2.6.17-rc3/arch/x86_64/kernel/traps.c
--- 2.6.17-rc3.org/arch/x86_64/kernel/traps.c 2006-05-10 12:07:30.000000000 +0800
+++ 2.6.17-rc3/arch/x86_64/kernel/traps.c 2006-05-10 12:18:53.000000000 +0800
@@ -141,50 +141,24 @@ static unsigned long *in_exception_stack
[DOUBLEFAULT_STACK - 1] = "#DF",
[STACKFAULT_STACK - 1] = "#SS",
[MCE_STACK - 1] = "#MC",
-#if DEBUG_STKSZ > EXCEPTION_STKSZ
- [N_EXCEPTION_STACKS ... N_EXCEPTION_STACKS + DEBUG_STKSZ / EXCEPTION_STKSZ - 2] = "#DB[?]"
-#endif
};
- unsigned k;
+ unsigned stack_size, end, k;
for (k = 0; k < N_EXCEPTION_STACKS; k++) {
- unsigned long end;
-
- switch (k + 1) {
-#if DEBUG_STKSZ > EXCEPTION_STKSZ
- case DEBUG_STACK:
- end = cpu_pda(cpu)->debugstack + DEBUG_STKSZ;
- break;
-#endif
- default:
- end = per_cpu(init_tss, cpu).ist[k];
- break;
- }
+ end = per_cpu(init_tss, cpu).ist[k];
if (stack >= end)
continue;
- if (stack >= end - EXCEPTION_STKSZ) {
+ if (k == (DEBUG_STACK - 1))
+ stack_size = DEBUG_STKSZ;
+ else stack_size = EXCEPTION_STKSZ;
+
+ if (stack >= end - stack_size) {
if (*usedp & (1U << k))
break;
*usedp |= 1U << k;
*idp = ids[k];
return (unsigned long *)end;
}
-#if DEBUG_STKSZ > EXCEPTION_STKSZ
- if (k == DEBUG_STACK - 1 && stack >= end - DEBUG_STKSZ) {
- unsigned j = N_EXCEPTION_STACKS - 1;
-
- do {
- ++j;
- end -= EXCEPTION_STKSZ;
- ids[j][4] = '1' + (j - N_EXCEPTION_STACKS);
- } while (stack < end - EXCEPTION_STKSZ);
- if (*usedp & (1U << j))
- break;
- *usedp |= 1U << j;
- *idp = ids[j];
- return (unsigned long *)end;
- }
-#endif
}
return NULL;
}
diff -Nruap 2.6.17-rc3.org/include/asm-x86_64/page.h 2.6.17-rc3/include/asm-x86_64/page.h
--- 2.6.17-rc3.org/include/asm-x86_64/page.h 2006-05-10 12:07:18.000000000 +0800
+++ 2.6.17-rc3/include/asm-x86_64/page.h 2006-05-10 12:19:24.000000000 +0800
@@ -20,7 +20,7 @@
#define EXCEPTION_STACK_ORDER 0
#define EXCEPTION_STKSZ (PAGE_SIZE << EXCEPTION_STACK_ORDER)
-#define DEBUG_STACK_ORDER EXCEPTION_STACK_ORDER
+#define DEBUG_STACK_ORDER 1
#define DEBUG_STKSZ (PAGE_SIZE << DEBUG_STACK_ORDER)
#define IRQSTACK_ORDER 2
next reply other threads:[~2006-05-10 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 6:45 bibo,mao [this message]
2006-05-10 7:08 ` [PATCH]x86_64 debug_stack nested patch Jan Beulich
2006-05-10 7:44 ` bibo,mao
2006-05-10 7:56 ` Jan Beulich
2006-05-10 8:26 ` bibo,mao
2006-05-10 10:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44618C0D.6020604@intel.com \
--to=bibo.mao@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.