All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <hcegtvedt@atmel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: Request to change enums to int in alsa-lib
Date: Wed, 10 May 2006 15:28:09 +0200	[thread overview]
Message-ID: <4461EA69.1040108@atmel.com> (raw)
In-Reply-To: <s5h1wv29fy3.wl%tiwai@suse.de>

Takashi Iwai wrote:
> At Wed, 10 May 2006 14:47:01 +0200,
> Hans-Christian Egtvedt wrote:

<snip>

>> I have attached a patch which changes all enums into ints, and the
>> library now works for me. I have no idea if I have broken something
>> else. I have another issue, but I'll post that in a separate email.
> 
> The change to include/sound/*.h looks OK.  Actually, the kernel side
> was already fixed to use int.  I was too lazy to update the alsa-lib
> side.
> 
> But, are other changes really necessary?  They are local in alsa-lib,
> so the size shouldn't matter.

I don't have the complete insight of which structs are being used
towards the kernel and which are just internal, so I did the "easy" way
of search and replace the entire library. If you, or somebody else with
good knowledge of the alsa library, redo my patch to those only used for
communication towards the kernel I can give it a go and see if it's
still good.

-- 
With kind regards,
Med vennlig hilsen,

Hans-Christian Egtvedt
Applications Engineer - AVR Applications Lab
Atmel Norway


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  reply	other threads:[~2006-05-10 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10 12:47 Request to change enums to int in alsa-lib Hans-Christian Egtvedt
2006-05-10 13:17 ` Takashi Iwai
2006-05-10 13:28   ` Hans-Christian Egtvedt [this message]
2006-05-10 13:32     ` Takashi Iwai
2006-05-10 13:59       ` Hans-Christian Egtvedt
2006-05-10 14:03         ` Takashi Iwai
2006-05-10 14:17           ` Hans-Christian Egtvedt
2006-05-10 14:27             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4461EA69.1040108@atmel.com \
    --to=hcegtvedt@atmel.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.