From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v5 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64 Date: Tue, 29 Nov 2016 10:22:12 +0100 Message-ID: <4463584.aXlFKgYRXe@diego> References: <1466734413-7453-9-git-send-email-zhengsq@rock-chips.com> <20161129004225.GA109697@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20161129004225.GA109697-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris Cc: Shunqian Zheng , joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, tfiga-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, xxm-TNX95d0MmH7DzftRWevZcw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Tomasz Figa , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org Am Montag, 28. November 2016, 16:42:27 schrieb Brian Norris: > Hi, > > On Fri, Jun 24, 2016 at 10:13:33AM +0800, Shunqian Zheng wrote: > > From: Simon Xue > > > > This patch makes it possible to compile the rockchip-iommu driver on > > ARM64, so that it can be used with 64-bit SoCs equipped with this type > > of IOMMU. > > > > Signed-off-by: Simon Xue > > Signed-off-by: Shunqian Zheng > > Signed-off-by: Tomasz Figa > > --- > > > > drivers/iommu/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index ad08603..5572621 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -218,7 +218,7 @@ config OMAP_IOMMU_DEBUG > > > > config ROCKCHIP_IOMMU > > > > bool "Rockchip IOMMU Support" > > > > - depends on ARM > > + depends on ARM || ARM64 > > > > depends on ARCH_ROCKCHIP || COMPILE_TEST > > select IOMMU_API > > select ARM_DMA_USE_IOMMU > > Whatever happened with the rest of this series? Some of the IOMMU bits > made it, but the DRM fixes never did, and so this didn't get applied. > This leaves the whole DRM stack unusable on ARM64 Rockchip systems. > > The patch context has changed a bit on patch 7 (and maybe 6?), so > somebody will need to refresh those on the latest upstream. I've tried forward-porting these when going through Caesars VOP dts patches, but was somewhat unsucessful in my small attempt at the time - see [0]. Heiko [0] https://lkml.org/lkml/2016/11/14/519 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Tue, 29 Nov 2016 10:22:12 +0100 Subject: [PATCH v5 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64 In-Reply-To: <20161129004225.GA109697@google.com> References: <1466734413-7453-9-git-send-email-zhengsq@rock-chips.com> <20161129004225.GA109697@google.com> Message-ID: <4463584.aXlFKgYRXe@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Montag, 28. November 2016, 16:42:27 schrieb Brian Norris: > Hi, > > On Fri, Jun 24, 2016 at 10:13:33AM +0800, Shunqian Zheng wrote: > > From: Simon Xue > > > > This patch makes it possible to compile the rockchip-iommu driver on > > ARM64, so that it can be used with 64-bit SoCs equipped with this type > > of IOMMU. > > > > Signed-off-by: Simon Xue > > Signed-off-by: Shunqian Zheng > > Signed-off-by: Tomasz Figa > > --- > > > > drivers/iommu/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index ad08603..5572621 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -218,7 +218,7 @@ config OMAP_IOMMU_DEBUG > > > > config ROCKCHIP_IOMMU > > > > bool "Rockchip IOMMU Support" > > > > - depends on ARM > > + depends on ARM || ARM64 > > > > depends on ARCH_ROCKCHIP || COMPILE_TEST > > select IOMMU_API > > select ARM_DMA_USE_IOMMU > > Whatever happened with the rest of this series? Some of the IOMMU bits > made it, but the DRM fixes never did, and so this didn't get applied. > This leaves the whole DRM stack unusable on ARM64 Rockchip systems. > > The patch context has changed a bit on patch 7 (and maybe 6?), so > somebody will need to refresh those on the latest upstream. I've tried forward-porting these when going through Caesars VOP dts patches, but was somewhat unsucessful in my small attempt at the time - see [0]. Heiko [0] https://lkml.org/lkml/2016/11/14/519 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756697AbcK2JWq (ORCPT ); Tue, 29 Nov 2016 04:22:46 -0500 Received: from gloria.sntech.de ([95.129.55.99]:45085 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756560AbcK2JW3 (ORCPT ); Tue, 29 Nov 2016 04:22:29 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Brian Norris Cc: Shunqian Zheng , joro@8bytes.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, mark.yao@rock-chips.com, airlied@linux.ie, tfiga@google.com, xxm@rock-chips.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomasz Figa , linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64 Date: Tue, 29 Nov 2016 10:22:12 +0100 Message-ID: <4463584.aXlFKgYRXe@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <20161129004225.GA109697@google.com> References: <1466734413-7453-9-git-send-email-zhengsq@rock-chips.com> <20161129004225.GA109697@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 28. November 2016, 16:42:27 schrieb Brian Norris: > Hi, > > On Fri, Jun 24, 2016 at 10:13:33AM +0800, Shunqian Zheng wrote: > > From: Simon Xue > > > > This patch makes it possible to compile the rockchip-iommu driver on > > ARM64, so that it can be used with 64-bit SoCs equipped with this type > > of IOMMU. > > > > Signed-off-by: Simon Xue > > Signed-off-by: Shunqian Zheng > > Signed-off-by: Tomasz Figa > > --- > > > > drivers/iommu/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index ad08603..5572621 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -218,7 +218,7 @@ config OMAP_IOMMU_DEBUG > > > > config ROCKCHIP_IOMMU > > > > bool "Rockchip IOMMU Support" > > > > - depends on ARM > > + depends on ARM || ARM64 > > > > depends on ARCH_ROCKCHIP || COMPILE_TEST > > select IOMMU_API > > select ARM_DMA_USE_IOMMU > > Whatever happened with the rest of this series? Some of the IOMMU bits > made it, but the DRM fixes never did, and so this didn't get applied. > This leaves the whole DRM stack unusable on ARM64 Rockchip systems. > > The patch context has changed a bit on patch 7 (and maybe 6?), so > somebody will need to refresh those on the latest upstream. I've tried forward-porting these when going through Caesars VOP dts patches, but was somewhat unsucessful in my small attempt at the time - see [0]. Heiko [0] https://lkml.org/lkml/2016/11/14/519